Auth: create session and validate signatures perform the same checks #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Enough for know, on creation it'll give an error. Backport to v5 and create a bugfix release. |
reinkrul
added a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signature verification performed more elaborate checks (employee details non-empty strings) than on session creation, which allows EmployeeID sessions to fail on input that was deemed valid earlier. That causes confusion, so should be the same.
Also, validation failure reason isn't logged or returned. Ideally it's returned to the client, but then we have to alter (extend) the OpenAPI spec. So for now, only log it.
Or should we still return it?