Discovery: opaque timestamp #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinkrul
requested review from
gerardsn and
woutslakhorst
and removed request for
gerardsn
woutslakhorst
requested changes
Dec 7, 2023
woutslakhorst
approved these changes
Dec 11, 2023
reinkrul
force-pushed
the
discovery-opaque-timestamp
branch
from
e0d6e31 to
1fe7014
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timestamp returned from server changed to string, to allow tags from multiple several to be discerned from each other.
Also changed the name to "tag" since timestamp indicates a clock and/or number. This makes having a lamport clock code-wise easier for function/type naming.