change gomigrate for dbmate #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
reinkrul
requested changes
Dec 6, 2023
reinkrul
reviewed
Dec 6, 2023
woutslakhorst
force-pushed
the
feature/2646/goose_migrations
branch
from
6ab2cdc to
37c4088
Compare
reinkrul
approved these changes
Dec 6, 2023
reinkrul
reviewed
Dec 6, 2023
| @@ -52,8 +52,6 @@ func Test_sqlStore_create(t *testing.T) { | |||
| verificationMethods, err := store.get(testDID) | |||
| require.NoError(t, err) | |||
| require.Len(t, verificationMethods, 2) | |||
| require.JSONEq(t, toJSON(vm1), toJSON(verificationMethods[0])) | |||
There was a problem hiding this comment.
maybe we should sort them, otherwise DID documents might change if order is not guaranteerd>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2646
there's one thingy: it requires a connection string so it opens a new connection to do migrations....