Refactor export instance video script (#541)

* Bugfix when no out_dir is provided * Reformatting, better error handling, change default codec * Added type hints * Formatting * Address review comments Co-authored-by: Holger Caesar <[email protected]>
nutonomy · Jan 11, 2021 · c839839 · c839839
1 parent 6e0ed36
commit c839839
Show file tree

Hide file tree

Showing 5 changed files with 298 additions and 254 deletions.
diff --git a/python-sdk/nuscenes/eval/prediction/submission/do_inference.py b/python-sdk/nuscenes/eval/prediction/submission/do_inference.py
@@ -31,7 +31,7 @@ def do_inference_for_submission(helper: PredictHelper,
     :param helper: Instance of PredictHelper that wraps the nuScenes test set.
     :param config: Instance of PredictionConfig.
     :param dataset_tokens: Tokens of instance_sample pairs in the test set.
-    :returns: List of predictions.
+    :return: List of predictions.
     """
 
     # User: Fill in the path to the model weights here.

diff --git a/python-sdk/nuscenes/eval/tracking/algo.py b/python-sdk/nuscenes/eval/tracking/algo.py
@@ -92,7 +92,7 @@ def name_gen(_threshold):
     def accumulate(self) -> TrackingMetricData:
         """
         Compute metrics for all recall thresholds of the current class.
-        :returns: TrackingMetricData instance which holds the metrics for each threshold.
+        :return: TrackingMetricData instance which holds the metrics for each threshold.
         """
         # Init.
         if self.verbose:
@@ -208,7 +208,7 @@ def accumulate_threshold(self, threshold: float = None) -> Tuple[pandas.DataFram
         Accumulate metrics for a particular recall threshold of the current class.
         The scores are only computed if threshold is set to None. This is used to infer the recall thresholds.
         :param threshold: score threshold used to determine positives and negatives.
-        :returns: (The MOTAccumulator that stores all the hits/misses/etc, Scores for each TP).
+        :return: (The MOTAccumulator that stores all the hits/misses/etc, Scores for each TP).
         """
         accs = []
         scores = []  # The scores of the TPs. These are used to determine the recall thresholds initially.

diff --git a/python-sdk/nuscenes/prediction/models/mtp.py b/python-sdk/nuscenes/prediction/models/mtp.py
@@ -60,7 +60,7 @@ def forward(self, image_tensor: torch.Tensor,
         :param image_tensor: Tensor of images shape [batch_size, n_channels, length, width].
         :param agent_state_vector: Tensor of floats representing the agent state.
             [batch_size, 3].
-        :returns: Tensor of dimension [batch_size, number_of_modes * number_of_predictions_per_mode + number_of_modes]
+        :return: Tensor of dimension [batch_size, number_of_modes * number_of_predictions_per_mode + number_of_modes]
             storing the predicted trajectory and mode probabilities. Mode probabilities are normalized to sum
             to 1 during inference.
         """