Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vlan trunk support on vm create #520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aapjeisbaas
Copy link

Support for vlan trunk.

I added both the api style notation and a user friendly version.

Api style:

      networks:
        - is_connected: True
          subnet:
            name: "{{ network_name }}"
          vlan_mode: "TRUNKED"
          trunked_vlan_list: [100, 200, 300, 400]

User friendly style (which overrides the api style:

      networks:
        - is_connected: True
          subnet:
            name: "{{ network_name }}"
          vlan_list: [100, 200, 300, 400]

@aapjeisbaas
Copy link
Author

@bhati-pradeep Can you have a look if you can merge this?
It has been working fine in our automated build and deployment pipeline.

@aapjeisbaas
Copy link
Author

aapjeisbaas commented Dec 17, 2024

#546

@bhati-pradeep bhati-pradeep added the 1.9.3_triage Bug fixes & Improvements label Dec 17, 2024
@bhati-pradeep
Copy link
Collaborator

bhati-pradeep commented Dec 17, 2024

@aapjeisbaas Thanks for raising PR. I will review it. Next release 2.0 is locked for any new items. Will track it under 1.9.3 release which will be for bug fixes and improvments

@@ -796,6 +839,33 @@ def get_module_spec():
("uuid", "bus"),
],
),
networks=dict(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already spec for networks in

Please update that existing spec instead of having it again here.
we import that here default_vm_spec = deepcopy(DefaultVMSpec.vm_argument_spec)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.9.3_triage Bug fixes & Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants