Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove terminationGracePeriodSeconds duplicated key #143

Conversation

pipoe2h
Copy link

@pipoe2h pipoe2h commented Apr 9, 2024

When using tools like Flux, the parser fails because there is a duplicated JSON key. When using helm it doesn't fails because K8s is more permissive than the parsers.

tuxtof
tuxtof previously approved these changes Apr 10, 2024
Copy link
Collaborator

@tuxtof tuxtof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

When using tools like Flux, the parser fails because there is a duplicated JSON key. When using helm it doesn't fails because K8s is more permissive than the parsers.
@tuxtof tuxtof force-pushed the pipoe2h-fix-terminationGracePeriodSeconds-duplicated-key branch from 24dbbf0 to c99dc83 Compare April 10, 2024 06:58
The chart version needs to be new. Increasing from 0.5.1 to 0.5.2
Copy link
Collaborator

@tuxtof tuxtof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuxtof tuxtof changed the base branch from master to ndb-operator-0.5.2 April 11, 2024 17:50
@tuxtof tuxtof merged commit 289afcd into nutanix:ndb-operator-0.5.2 Apr 11, 2024
1 check passed
@pipoe2h pipoe2h deleted the pipoe2h-fix-terminationGracePeriodSeconds-duplicated-key branch April 11, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants