Skip to content

Commit

Permalink
[balsa] Update comment for line folding tests. (envoyproxy#35003)
Browse files Browse the repository at this point in the history
Signed-off-by: Bence Béky <[email protected]>
  • Loading branch information
bencebeky authored Jul 8, 2024
1 parent bb9fbf0 commit a7f4da3
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions test/common/http/http1/codec_impl_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4873,10 +4873,11 @@ TEST_P(Http1ClientConnectionImplTest, InvalidCharacterInTrailerName) {
EXPECT_EQ(status.message(), "http/1.1 protocol error: HPE_INVALID_HEADER_TOKEN");
}

// When receiving header value with obsolete line folding, `obs-fold` should be replaced by SP.
// This is http-parser's behavior. BalsaParser does not support obsolete line folding and rejects
// such messages (also permitted by the specification). See RFC9110 Section 5.5:
// https://www.rfc-editor.org/rfc/rfc9110.html#name-field-values.
// When receiving a message with obsolete line folding, `obs-fold` should be replaced by one or more
// SP characters, see RFC9110 Section 5.5:
// https://www.rfc-editor.org/rfc/rfc9112.html#name-obsolete-line-folding.
// However, both http-parser and BalsaParser simply strip the `\r\n`, and keep the SP or TAB at the
// beginning of the next line.
TEST_P(Http1ServerConnectionImplTest, ObsFold) {
// SPELLCHECKER(off)
initialize();
Expand Down

0 comments on commit a7f4da3

Please sign in to comment.