Fix wrong unit when split string

[petricavalry]

Fixes #837.

reedline/src/menu/columnar_menu.rs

Line 305 in 4634f71

let (match_str, remaining_str) = suggestion.value.split_at(match_len);

split_at expect byte offset.

reedline/src/menu/columnar_menu.rs

Line 302 in 4634f71

let match_len = self.working_details.shortest_base_string.width();

But we given (got from width) isn't.

Thanks for all amazing works in reedline.

[sholderbach]

Yeah for anything involving string splitting .len is the relevant thing to get to the indices, while .width serves as a best guess for the layout width in the terminal. We need to be sure that the right thing is used in the right place.

There seems to be some preexisting history of display bugs leading to this

• Column menu spaces don't respect special characters (accents, emojis...) #793
• Fix #793 using width() for column menu alignements with special char #794

[petricavalry]

Thanks for your help. I can't reproduce #793 after change this line. match_len is used only to split string.

[Jiogo18]

Works well, sorry about that.

The comment I wrote in #794 doesn't make sense, it is about str_len

shortest_base_string (in case all the results contains lots of special characters)

[sholderbach]

Thx for the fix!