[WIP] History API rework #747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add builder functions * fix description wrap * fmt * fix
|
Seems like this won't materialize. I'm not sure we'd accept it anyway. I'd suggest smaller PRs so they're easier to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is a work-in-progress, and is not ready to be merged as-is. There are ongoing discussions about the new API design.
This PR aims to overhaul the history API of reedline in order to make it usable outside of the crate. It also aims to make it more robust, more intuitive and less error-prone.
Following discussions in #680 (original PR), #735 (discussion), also embedding future discussions for #746.
For newcomers in the discussion, please read #680 first, as it will help you understand the motivations and existing discussion behind this PR.
TODO list (includes unvoted tasks):
sled-backed?)syncAPI (see Sync history after each insert #746)History::sessionmethod someplace else (to move session detection logic outside of the history implementation)cc @stormasm @fdncred @sholderbach