Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add style from #691 to ide menu #722

Merged
merged 16 commits into from
Jan 26, 2024
Merged

add style from #691 to ide menu #722

merged 16 commits into from
Jan 26, 2024

Conversation

maxomatic458
Copy link
Contributor

No description provided.

@fdncred
Copy link
Collaborator

fdncred commented Jan 25, 2024

What does this look like now with a style?

@maxomatic458
Copy link
Contributor Author

@fdncred here is a screenshot
grafik
(my terminal colors make it look a bit dark, but its the same as in #691)

@fdncred
Copy link
Collaborator

fdncred commented Jan 25, 2024

Thanks. That looks cool!!

@stormasm
Copy link
Contributor

stormasm commented Jan 25, 2024

@maxomatic458 just curious to know why when you do PRs do you work off your main branch ?

I think it would be easier if you created a branch first and then started working on the PR...

This way if one of your PRs doesn't land right away you can update your main to the latest version of Reedline (for example) and then start another PR by branching off main....

The reason I mention this is because of your revert above when you started working on menu refactor and then had to revert because you were on the main branch where this PR is located...

@maxomatic458
Copy link
Contributor Author

@stormasm
Yea i was to lazy to make a branch for a small pr like this.

And i forgot that i was still on main when starting to work on refactoring the menus.

I should probably start doing that.

@stormasm stormasm merged commit 03a1bab into nushell:main Jan 26, 2024
6 checks passed
@stormasm
Copy link
Contributor

@maxomatic458 can you please post the style setting along with the config.nu stuff surrounding it so I can test it with my nushell config.nu

Thanks !

@maxomatic458
Copy link
Contributor Author

@stormasm i think this only works with external completers (so nothing needs to be changed in nushells config) i used https://carapace.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants