Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docs.rs docs with all features #672

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

sholderbach
Copy link
Member

Inspired by nushell/nushell#11180

Make sure you can see all available types/symbols on docs.rs
(e.g. SqliteBackedHistory)

In a second step we should take care of annotating feature gated stuff
correctly

Inspired by nushell/nushell#11180

Make sure you can see all available types/symbols on docs.rs
(e.g. `SqliteBackedHistory`)

In a second step we should take care of annotating feature gated stuff
correctly
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #672 (71e62f2) into main (93af55c) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   49.19%   49.16%   -0.03%     
==========================================
  Files          46       46              
  Lines        7930     7926       -4     
==========================================
- Hits         3901     3897       -4     
  Misses       4029     4029              

see 3 files with indirect coverage changes

@fdncred fdncred merged commit 37714c9 into nushell:main Nov 29, 2023
8 checks passed
@fdncred
Copy link
Collaborator

fdncred commented Nov 29, 2023

Agreed.

@sholderbach sholderbach deleted the fix-docsrs branch December 12, 2023 22:31
@sholderbach
Copy link
Member Author

Apparently this failed with the clipboard feature in the sandbox of docs.rs

https://docs.rs/crate/reedline/0.27.0/builds/1059493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants