Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vi mode: map cw/cW to ce/cE by default #668

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

crides
Copy link
Contributor

@crides crides commented Nov 15, 2023

make cw/cW delete uptil the next space (like ce/cE). See the vim help page on cw. This behavior is in both zsh and bash

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #668 (b9659f4) into main (93af55c) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
+ Coverage   49.19%   49.20%   +0.01%     
==========================================
  Files          46       46              
  Lines        7930     7928       -2     
==========================================
  Hits         3901     3901              
+ Misses       4029     4027       -2     
Files Coverage Δ
src/edit_mode/vi/command.rs 30.86% <0.00%> (+0.37%) ⬆️

@sholderbach
Copy link
Member

The title was at first a little confusing but you are correct when it comes to the behavior until which character things are changed (if starting on a word. Thanks for linking to the documentation as well! As described in the docs there is a slight difference between ce and cw when on whitespace. so this change wouldn't reflect that, but it would be a judgemeent call if we want to implement that as a separate op before simplifiying things internally for text objects (ciw my beloved).

@sholderbach sholderbach merged commit ff5fdb0 into nushell:main Dec 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants