external completer: support style

[rsteube]

Description

Adds style support.

Reverse highlighting is recommended for the completion-menu:

style: {
    text: white
    selected_text: {
        attr: r
    }
    description_text: white_dimmed
}

needs nushell/reedline#691
related #5292
fix carapace-sh/carapace#967

User-Facing Changes

Style support for values during completion:

Tests + Formatting

After Submitting

[rsteube]

This can be tested with v0.29 of carapace.
Config needs the new spread operator:

let external_completer = {|spans|
    carapace $spans.0 nushell ...$spans | from json
}

[fdncred]

@rsteube Can we get this CI green (seems like you're working on it). I was updating to the latest nu-ansi-term and lscolors and can't compile nushell because of this.

[rsteube]

Ah yes, saw the lscolors release and was just updating the branch.

[fdncred]

Does the default_config.nu need to change to support this? It doesn't seem like it's working very good with my config. I can't tell which item is selected.

This is what I typically use

    style: {
      text: { fg: "#33ff00" }
      selected_text: { fg: "#0c0c0c" bg: "#33ff00" attr: b}
      description_text: yellow
    }

[rsteube]

Yes, reverse (r) highlighting would be best:

            style: {
                text: white
                selected_text: {
                    attr: r
                }
                description_text: white_dimmed
            }

[fdncred]

The reason the colors are configurable are so people can configure them. Seems like this change should respect the colors specified, especially since they provide fg and bg.

Also, it seems incomplete to just have one color now for selected text. Shouldn't there be one for the value and one for description?

[fdncred]

It seems like the default_config.nu should have this for the completion_menu, so it keeps with our green theme, unless we decide to change the value and the description color via style.

            style: {
                text: green
                selected_text: {attr: r}
                description_text: yellow
            }

[rsteube]

The reason the colors are configurable are so people can configure them. Seems like this change should respect the colors specified, especially since they provide fg and bg.

Yeah, think I'll need to have another look at that in reedline.

Also, it seems incomplete to just have one color now for selected text. Shouldn't there be one for the value and one for description?

Possible 🤔

[fdncred]

ok, i landed that reedline change. @rsteube when you get a chance can you update reedline in this PR (cargo update -p reedline) and whatever else needs to be changed based on your most recent reedline PR?

[fdncred]

@rsteube would you mind rebasing (or fixing some other way)? I keep getting this when I check out your PR.

[fdncred]

This one is clearly not your fault. We're going to have to get that fixed and do another rebase. Sorry.

[fdncred]

ok, just landed #11638 which should fix this CI problem. if you could rebase again please.

[fdncred]

Thanks. I tested this and I think it's finally ready to land. Thanks for your help!