throw a little error when there are failures

[amtoine]

related to

• rewrite the library: simpler design and implementation, unit tests amtoine/nu-git-manager#26

Description

after amtoine/nu-git-manager#26, i would like to add nupm test to the CI 👌

however, currently, nupm test does not return a true error when the tests fail and thus won't crash a CI 🤔

this PR throws a real error the number of $failures is non-zero 👍

example

let's introduce an obvious error in the tests of nupm itself

diff --git a/tests/mod.nu b/tests/mod.nu
index b20e9bc..7d0fbac 100644
--- a/tests/mod.nu
+++ b/tests/mod.nu
@@ -22,6 +22,8 @@ export def install-script [] {
             | path join
             | path exists)
     }
+
+    assert false
 }
 
 export def install-module [] {

running nupm test; print "all tests passed" should not print the string

• before the changes: it did

Testing package /home/amtoine/documents/repos/github.com/amtoine/nupm
tests install-module ... SUCCESS
tests install-script ... FAILURE
tests install-custom ... SUCCESS

Test "tests install-script" failed with exit code 1:
2023-10-10T19:10:54.072|INF|installing package spam_script
Error:   × Assertion failed.
    ╭─[/home/amtoine/documents/repos/github.com/amtoine/nupm/tests/mod.nu:25:1]
 25 │
 26 │     assert false
    ·            ──┬──
    ·              ╰── It is not true.
 27 │ }
    ╰────

Ran 3 tests. 2 succeeded, 1 failed.
all test passed

• after the changes: it does not anymore

Testing package /home/amtoine/documents/repos/github.com/amtoine/nupm
tests install-module ... SUCCESS
tests install-script ... FAILURE
tests install-custom ... SUCCESS

Test "tests install-script" failed with exit code 1:
2023-10-10T19:10:59.395|INF|installing package spam_script
Error:   × Assertion failed.
    ╭─[/home/amtoine/documents/repos/github.com/amtoine/nupm/tests/mod.nu:25:1]
 25 │
 26 │     assert false
    ·            ──┬──
    ·              ╰── It is not true.
 27 │ }
    ╰────

Ran 3 tests. 2 succeeded, 1 failed.
Error:   × some tests failed

[kubouch]

Thanks, seems like a nice QoL touch, we should be returning an error. We might need to redesign the reporting a bit in the future.

[amtoine]

We might need to redesign the reporting a bit in the future.

yup agree there is room for improvement 👍

Thanks, seems like a nice QoL touch, we should be returning an error.

at least for now it will not run past a failing nupm test 🙏