-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AY1920S1-CS2113-F10-3] AlphaNUS #78
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add more unit tests.
Consider using switch case and enum for keyword matching
src/main/java/AlphaNUS.java
Outdated
private static Ui ui; | ||
private static TaskList tasklist; | ||
private static Storage storage; | ||
private static HashMap<String, Payee> managermap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use camel case for variable name
src/main/java/Main.java
Outdated
//import javafx.application.Application; | ||
//import javafx.scene.Scene; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete, don't comment out
package command; | ||
|
||
public class Instruction { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the whole class, extract the strings into variables
src/main/java/command/Parser.java
Outdated
* @return Returns boolean variable to indicate when to stop parsing for input. | ||
* @throws AlphaNUSException if input is not valid. | ||
*/ | ||
public static boolean parse(String input, TaskList tasklist, Ui ui, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider switch case
Added HIstory feature to DG
Add Payee Feature to DG
history feature DG
added sequence diagram for history
Updated DG
…edHashMap for easier iteration
update 28.oct
…ap, Integrated Projectmap into Payments functions
implemented assign fund feature
# Conflicts: # data/duke.txt # src/main/java/command/Parser.java
Removed debugging line
Removed debugging line
Fixed UG merge conflicts
updated UG
Update for Dev Guide
updated tasks
Updated PPP, Unit Tests, Command formats
Updated Unit Tests
updated dg
update ugdg and ppp
@lijiayu980606
@karansarat
@E0373902