Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AY1920S1-CS2113-F10-3] AlphaNUS #78

Open
wants to merge 476 commits into
base: master
Choose a base branch
from

Conversation

leowyh
Copy link

@leowyh leowyh commented Oct 3, 2019

Copy link

@langyanbin0314 langyanbin0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add more unit tests.
Consider using switch case and enum for keyword matching

private static Ui ui;
private static TaskList tasklist;
private static Storage storage;
private static HashMap<String, Payee> managermap;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use camel case for variable name

Comment on lines 5 to 6
//import javafx.application.Application;
//import javafx.scene.Scene;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete, don't comment out

package command;

public class Instruction {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the whole class, extract the strings into variables

* @return Returns boolean variable to indicate when to stop parsing for input.
* @throws AlphaNUSException if input is not valid.
*/
public static boolean parse(String input, TaskList tasklist, Ui ui,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider switch case

E0373902 and others added 26 commits October 25, 2019 03:38
Added HIstory feature to DG
added sequence diagram for history
…ap, Integrated Projectmap into Payments functions
implemented assign fund feature
# Conflicts:
#	data/duke.txt
#	src/main/java/command/Parser.java
karansarat and others added 30 commits November 11, 2019 21:50
Updated PPP, Unit Tests, Command formats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants