[Dexter Hoon] iP #68

DextheChik3n · 2023-09-05T00:22:41Z

No description provided.

CerIsaiah · 2023-09-07T09:49:26Z

src/main/java/Alan.java

+                //unmark tasks as undone
+                String[] words = userInput.split(" ");
+
+                tasks[Integer.parseInt(words[1])].setDone(false);


Could you rename this line as a variable, seeing as you use it later in your code?

Thanks for the suggestion... I think it could be helpful to do this as it can make my code neater :D

src/main/java/Task.java

CerIsaiah · 2023-09-07T09:54:03Z

src/main/java/Alan.java


                System.out.println("Ok, I've marked this task as not done yet:");
-                System.out.println("\t[" + taskList[Integer.parseInt(words[1])].getStatusIcon() + "] " +
-                        taskList[Integer.parseInt(words[1])].getDescription());
+                System.out.println("\t[" + tasks[Integer.parseInt(words[1])].getStatusIcon() + "] " +


Maybe making some variables statement could make this less verbose

I agree... will probably do that since it does look very complex and hard to understand what is going on

src/main/java/Alan.java

skylee03

The code quality is very high!

skylee03 · 2023-09-07T10:19:48Z

src/main/java/Alan.java

+                System.out.println("\t[" + tasks[Integer.parseInt(words[1])].getStatusIcon() + "] " +
+                        tasks[Integer.parseInt(words[1])].getDescription());


Try to avoid complicated expressions.

Yeah very true... I will follow what someone else suggested by using more variables to simplify the statement

skylee03 · 2023-09-07T10:20:44Z

src/main/java/Alan.java

+        System.out.println("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~");
+    }
+
+    public static void main(String[] args) {


Try to avoid long methods. You can try to extract part of the code into other methods.

Alright sure I can try to break the long method into smaller methods to handle each of the commands which can make it easier to debug and organise my code

src/main/java/Alan.java

woowenjun99

Good job on the PR! Here are some feedbacks:

Perhaps you would like to consider reviewing the variable names as I noticed that there was variable shadowing (i.e. currentTasksIndex is used as an attribute name as well as a parameter in the function).

Also, perhaps do you want to consider the standardisation of the use of variables and magic strings? I noticed that you declared variables for the error messages but not for the other messages and hence magic strings still exists.

Do you also want to consider using attributes for the tasks array and user input because it is the class' property and many methods will use them over and over again?

Finally, do you want to relook at the code readability as I noticed that many attributes and methods were not spaced consistently, making it difficult to read. Do you want to have a look at switch case or String.formatf

woowenjun99 · 2023-09-14T02:45:37Z

src/main/java/Alan.java

+    public static void printTaskAddedMessage(Task[] tasks, int currentTasksIndex) {
+        System.out.println("added: " + tasks[currentTasksIndex]);
+        System.out.println("Now you have " + currentTasksIndex + " in the list.");
+    }


Do you want to consider changing the variable name for the currentTasksIndex as I noticed that it shares the same name as the class attribute and might be ambiguous (have to be more careful in the future)?

woowenjun99 · 2023-09-14T03:04:35Z

src/main/java/Task.java

+        this.description = description;
+    }
+
+    public boolean getDone() {


Perhaps you would like to use a more boolean name for this method

Add Date parsing for deadline and event tasks

# Conflicts: # src/main/java/alan/parser/Parser.java

Add find task functionality

# Conflicts: # src/main/java/alan/data/exception/AlanException.java # src/main/java/alan/parser/Parser.java # src/main/java/alan/storage/Storage.java # src/main/java/alan/ui/Ui.java

Add JavaDoc comments

DextheChik3n added 9 commits August 24, 2023 22:48

Rename main class

c606c3c

Add greeting and exit functions

e3f01fa

Refactor printHorrizontalLine function

3afcb6b

Add echo function

184e708

Add list functionality

cf80b82

Add Task.java class

1afaaf1

Add mark and unmark tasks feature

e331bb9

Main.java: Fix handling exit command

951a3e6

Update Alan.java to follow coding standard

7a7066d

DextheChik3n changed the title ~~[Dexter] iP~~ [Dexter Hoon] iP Sep 5, 2023

CerIsaiah reviewed Sep 7, 2023

View reviewed changes

skylee03 reviewed Sep 7, 2023

View reviewed changes

DextheChik3n added 8 commits September 7, 2023 21:22

Add todo, deadline and event tasks

32601dd

Update input.txt and EXPECTED.TXT for automated testing

ff60709

Refactor Alan class

3550db1

Refactor Alan.java

ae095d1

Add error handling for invalid command and todo tasks

31437f8

Add error handling for deadline and event invalid input formatting

511f4d2

Add error handling for mark/unmark unknown tasks

eb7f6ae

Merge branch 'branch-Level-5'

b168238

woowenjun99 reviewed Sep 14, 2023

View reviewed changes

Change message texts

4194ba3

DextheChik3n force-pushed the master branch from 1bc81a4 to 4194ba3 Compare September 14, 2023 13:39

DextheChik3n added 7 commits September 14, 2023 21:42

Organize classes into java packages

8365fc3

Merge branch 'branch-A-Packages'

44587d6

Refactor error exception and command handling

c7bcaaa

Change Alan to store tasks in ArrayList

17b65ef

Add delete function

1933454

Update tasks to set and get task contents

41ce6df

Add saving task list to text file functionality

88bace6

DextheChik3n and others added 30 commits September 20, 2023 23:55

Add saving and loading tasks from text file

a49e395

Merge branch 'branch-Level-6'

23738a8

Merge branch 'branch-Level-7'

3dab5c7

Refactor read function in Alan.java

425e388

.gitignore: add MANIFEST.MF

b6ecfbe

Create packages to organise java classes

eeee528

Create classes to organise code

d7ccba5

Implement UI Class

361eb39

Implement TaskList class

4935bba

Implement Parser class

7f3c631

Implement Storage class

d140956

Add reading invalid task type in Storage class

2d45aff

Add date parsing

310e2b4

Add find task functionality

61e0f3c

Merge pull request #1 from DextheChik3n/branch-Level-8

4c9970f

Add Date parsing for deadline and event tasks

Add JavaDoc comments

51959a1

Merge branch 'master' into branch-Level-9

64c21f4

# Conflicts: # src/main/java/alan/parser/Parser.java

Merge branch 'master' into branch-A-JavaDoc

4b5849c

# Conflicts: # src/main/java/alan/parser/Parser.java

Merge pull request #2 from DextheChik3n/branch-Level-9

4bac978

Add find task functionality

Merge branch 'master' into branch-A-JavaDoc

ef54d91

# Conflicts: # src/main/java/alan/data/exception/AlanException.java # src/main/java/alan/parser/Parser.java # src/main/java/alan/storage/Storage.java # src/main/java/alan/ui/Ui.java

Merge pull request #3 from DextheChik3n/branch-A-JavaDoc

c63d05e

Add JavaDoc comments

Update README.md

7efbd2b

Remove Command Summary section from README.md

4a0b8b8

Refactor magic strings

151f23c

Add error handling for empty user input

1f42faa

Add handling of printing empty lists

efc4ab2

Add error handling for mark, unmark and delete command

036f277

Remove unused imports

f67cbbf

Update README.md

6cc4255

Fix storing empty TaskList to text file

e4f770e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dexter Hoon] iP #68

[Dexter Hoon] iP #68

DextheChik3n commented Sep 5, 2023

CerIsaiah Sep 7, 2023

DextheChik3n Sep 7, 2023

CerIsaiah Sep 7, 2023

DextheChik3n Sep 7, 2023

skylee03 left a comment

skylee03 Sep 7, 2023

DextheChik3n Sep 7, 2023

skylee03 Sep 7, 2023

DextheChik3n Sep 7, 2023

woowenjun99 left a comment •

edited

Loading

woowenjun99 Sep 14, 2023

woowenjun99 Sep 14, 2023

		System.out.println("\t[" + tasks[Integer.parseInt(words[1])].getStatusIcon() + "] " +
		tasks[Integer.parseInt(words[1])].getDescription());

[Dexter Hoon] iP #68

Are you sure you want to change the base?

[Dexter Hoon] iP #68

Conversation

DextheChik3n commented Sep 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skylee03 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

woowenjun99 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

woowenjun99 left a comment •

edited

Loading