[bljhty] iP #65

bljhty · 2023-09-04T16:36:49Z

No description provided.

renamed chatbot from duke to Dom, added the various lines

imporved on level-2 code completed level-3

SebasFok

Looks good! Very clear comments used to allow readers to understand your train of thought

SebasFok · 2023-09-07T09:52:24Z

src/main/java/Duke.java

        System.out.println("Hello from\n" + logo);
+        String greetings = "____________________________________________________________" + "\n" +


Could the line be stored in a string variable so that it could be used more easily elsewhere when formatting?

SebasFok · 2023-09-07T09:54:18Z

src/main/java/Duke.java

+     * This method prints the list of tasks.
+     */
+    private static void listTasks(ArrayList<Task> tasks) {
+        if (tasks.isEmpty()) {


I like how you considered the case when the list is empty so that the user knows that his input was read.

SebasFok · 2023-09-07T09:56:14Z

src/main/java/Duke.java

+            Task task = tasks.get(i);
+            String taskType = task instanceof Todo ? "[T]" : (task instanceof Deadline ? "[D]" : "[E]");
+            String statusIcon = task.getStatusIcon();
+            String description = task.getDescription();
+
+            if (task instanceof Deadline) {
+                description += " (by: " + ((Deadline) task).getBy() + ")";
+            } else if (task instanceof Event) {
+                description += " (from: " + ((Event) task).getFrom() + " to: " + ((Event) task).getTo() + ")";
+            }
+
+            System.out.println(" " + (i + 1) + "." + taskType + statusIcon + " " + description);


I like how you broke the sentence up into multiple parts such that it is easy to modify it in the future. There is also good use of white spaces to make make the sentence clear to the reader.

SebasFok · 2023-09-07T10:00:11Z

src/main/java/Duke.java

+                String command = givenTask.nextLine();
+                System.out.println("____________________________________________________________");
+
+                if (command.equalsIgnoreCase("bye")) {


Could the if else statements be changed to switch statements for better readability? This could make each branch easier to find and edit in the future.

This reverts commit 75ddef5.

* Branch-Level-5: Level-5 increment + edit code edited code # Conflicts: # src/main/java/Duke.java

This reverts commit f50b1a3.

* branch-A-package: included packages

irving11119

Overall, your code follows the coding standards and your naming conventions are good. However, do try to avoid deep nested as it affects readability of code and try to use constants rather than magic strings and numbers!

irving11119 · 2023-09-17T04:41:14Z

text-ui-test/tempCodeRunnerFile.sh

@@ -0,0 +1 @@
+/Users/bryanlee/Desktop/NUS/NUS Y3S1/CS2113/ip/src/main/java/Duke.java


Perhaps you could add this file to your .gitignore.

irving11119 · 2023-09-17T04:42:59Z

src/main/java/Duke.java

+        System.out.println(goodbye);
+    }
+
+    public static void getHelp() {


Perhaps you could consider making this a named constant instead to avoid having magic strings.

irving11119 · 2023-09-17T05:03:51Z

src/main/java/Duke.java

+                    } else if (command.startsWith("mark")) {
+                        if (command.substring(5).isEmpty()) {
+                            System.out.println("Error: Task number cannot be empty\n");
+                            System.out.println("Please enter command in the format: mark <task number>");
+                        }
+                        try {
+                            String[] parts = command.split(" ");
+                            if (parts.length == 2) {
+                                int taskIndex = Integer.parseInt(parts[1]) - 1;
+                                if (taskIndex >= 0 && taskIndex < tasks.size()) {
+                                    Task task = tasks.get(taskIndex);
+                                    task.markAsDone(true);
+                                    System.out.println(
+                                            " Nice! I've marked this task as done:\n" + "   " + task.getStatusIcon()
+                                                    + " " + task.getDescription());
+                                } else {
+                                    System.out.println(" Invalid task number.");
+                                }
+                            }
+                        } catch (NumberFormatException e) {
+                            System.out.println("Please enter a valid task number");
+                        }


Try to avoid deep nesting here and elsewhere in your code. Instead you could try to implement some of the nested logic in another method and call the method!

change from else if statements to case statements

* branch-level-6: Level-6 increment done

* branch-level-7: added level-7 increments # Conflicts: # src/main/java/Duke.java

Level-9 increment done

* 'master' of https://github.com/bljhty/ip: Level-9 increment done

added more javaDoc

added changes to userguide

bljhty added 7 commits August 26, 2023 16:14

Update Duke.java

a14a728

renamed chatbot from duke to Dom, added the various lines

Level 0 increment, edited code

cbd58cc

Level 1

b5b91a4

Completed Level 2 increment and updated code

82224dd

Added Task.java file,

59939a7

imporved on level-2 code completed level-3

edited code

8b1d144

level-4 completed, edited code

cdbc6b6

SebasFok reviewed Sep 7, 2023

View reviewed changes

bljhty added 10 commits September 13, 2023 12:45

edited code

cb72979

Level-5 increment + edit code

75ddef5

no message

41ac331

Revert "Level-5 increment + edit code"

e8ec876

This reverts commit 75ddef5.

Merge branch 'Branch-Level-5'

6515beb

* Branch-Level-5: Level-5 increment + edit code edited code # Conflicts: # src/main/java/Duke.java

changes to code

f50b1a3

Revert "changes to code"

4607c85

This reverts commit f50b1a3.

edited code

4729a1e

included packages

6469a2f

Merge branch 'branch-A-package'

f5e82cd

* branch-A-package: included packages

irving11119 reviewed Sep 17, 2023

View reviewed changes

bljhty and others added 11 commits September 19, 2023 23:19

edited code:

9627039

change from else if statements to case statements

Level-6 increment done

1bb1859

added level-7 increments

39957f7

Merge branch 'branch-level-6'

c5f0139

* branch-level-6: Level-6 increment done

Merge branch 'branch-level-7'

352ca3b

* branch-level-7: added level-7 increments # Conflicts: # src/main/java/Duke.java

edited code

638e421

edited some code

9119029

edited code, increment: A-MoreOOP done

85aaecb

edited code

614e4d6

Level-9 increment done

23e63d4

Merge pull request #2 from bljhty/branch-Level-9

d89ca68

Level-9 increment done

bljhty and others added 8 commits September 30, 2023 18:46

Merge branch 'master' of https://github.com/bljhty/ip

aba7f13

* 'master' of https://github.com/bljhty/ip: Level-9 increment done

added javadoc

fe6c10e

improved code, added readme

a99d632

added more javaDoc

7a6474b

Merge pull request #3 from bljhty/branch-A-JavaDoc

e9b75a3

added more javaDoc

added changes to userguide

1f20765

Merge pull request #4 from bljhty/branch-A-UserGuide

d6cede0

added changes to userguide

refactored code and make changes to code

4814f11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bljhty] iP #65

[bljhty] iP #65

bljhty commented Sep 4, 2023

SebasFok left a comment

SebasFok Sep 7, 2023

SebasFok Sep 7, 2023

SebasFok Sep 7, 2023

SebasFok Sep 7, 2023

irving11119 left a comment

irving11119 Sep 17, 2023

irving11119 Sep 17, 2023

irving11119 Sep 17, 2023

		System.out.println("Hello from\n" + logo);
		String greetings = "____________________________________________________________" + "\n" +

		@@ -0,0 +1 @@
		/Users/bryanlee/Desktop/NUS/NUS Y3S1/CS2113/ip/src/main/java/Duke.java

[bljhty] iP #65

Are you sure you want to change the base?

[bljhty] iP #65

Conversation

bljhty commented Sep 4, 2023

SebasFok left a comment

Choose a reason for hiding this comment

SebasFok Sep 7, 2023

Choose a reason for hiding this comment

SebasFok Sep 7, 2023

Choose a reason for hiding this comment

SebasFok Sep 7, 2023

Choose a reason for hiding this comment

SebasFok Sep 7, 2023

Choose a reason for hiding this comment

irving11119 left a comment

Choose a reason for hiding this comment

irving11119 Sep 17, 2023

Choose a reason for hiding this comment

irving11119 Sep 17, 2023

Choose a reason for hiding this comment

irving11119 Sep 17, 2023

Choose a reason for hiding this comment