[Chua Zhong Heng] iP #63

Cazh1 · 2023-09-04T16:03:04Z

No description provided.

karishma-t

lgtm! good use of encapsulation

karishma-t · 2023-09-07T09:59:04Z

src/main/java/Nuke.java

+    public static void printLine() {
+        System.out.println("    ____________________________________________________________");
+    }
+


Can consider adding javadoc comments for each method for greater clarity.

karishma-t · 2023-09-07T10:06:28Z

src/main/java/Nuke.java

+            add(itemList, markList, item);
+        }
+        dialogue(itemList, markList);
+    }


Good use of naming standards, e.g camelCase

karishma-t · 2023-09-07T10:09:53Z

src/main/java/Nuke.java

+        }
+        printLine();
+    }
+


Good layout structure

karishma-t · 2023-09-07T10:12:41Z

src/main/java/Nuke.java

+            int listIndex = Integer.parseInt(splitItem[1]);
+            unmark(itemList, markList, listIndex);
+        } else {
+            add(itemList, markList, item);


indentations just require one more space

ShaniceTang

Overall, your coding quality is very well done and your code is readable! Great job! 💯

ShaniceTang · 2023-09-07T10:21:21Z

src/main/java/Nuke.java

+            printLine();
+            System.out.println(item);
+            printLine();
+            echo();


Nice!
I like that you use recursion :)

ShaniceTang · 2023-09-07T10:29:22Z

src/main/java/Nuke.java

+            int listIndex = Integer.parseInt(splitItem[1]);
+            mark(itemList, markList, listIndex);
+        } else if (item.length() > 6 && item.substring(0, 6).equals("unmark")) {
+            String[] splitItem = item.split(" ");


Could this array be named "items" instead?

ShaniceTang · 2023-09-07T10:29:53Z

src/main/java/Nuke.java

+        printLine();
+    }
+
+    public static void main(String[] args) {


I like that your main method is short and neat :D

ShaniceTang · 2023-09-07T10:30:36Z

src/main/java/Nuke.java

+    public static void dialogue(ArrayList<String> itemList, ArrayList<String> markList) {
+        Scanner input = new Scanner(System.in);
+        String item = input.nextLine();
+         if (item.equals("bye")) {


I like that you use else-if instead of nesting 👍

This reverts commit 3dbdfbc.

Add Error Handling function

woowenjun99

Good job on your first milestone! Not to bad, just that perhaps you might want to consider replacing all the magic number and magic string with variables and not sure if I am correct, there is a recursive call.

woowenjun99 · 2023-09-14T15:54:00Z

src/main/java/Event.java

@@ -0,0 +1,15 @@
+public class Event extends Task{


Perhaps you want to add an additional space in front of the curly paranthesis?

woowenjun99 · 2023-09-14T15:56:00Z

src/main/java/KenergeticBot.java

+        printLine();
+        System.out.println("     Here are the tasks in your list:");
+        for (int i = 0; i < taskList.size(); i++) {
+            System.out.printf("     %d.%s\n", i+1, taskList.get(i));


Nice to use printf!

woowenjun99 · 2023-09-14T15:57:17Z

src/main/java/KenergeticBot.java

+
+    public static void printGreetingMessage() {
+        printLine();
+        System.out.println("     Hello! I'm KenergeticBot\n" + "     What can I do for you?");


Perhaps you would like to replace all the magic strings and numbers in your code with variables for greater readability?

woowenjun99 · 2023-09-14T16:02:33Z

src/main/java/KenergeticBot.java

+                System.out.println(KenergeticBotException.INVALID_COMMAND); // unable to print sad face ˙◠˙
+            }
+        }
+        botDialogue(taskList);


Is this recursion???

woowenjun99 · 2023-09-14T16:03:31Z

src/main/java/KenergeticBotException.java

+
+

Perhaps you would like to remove these extra spaces?

woowenjun99 · 2023-09-14T16:04:33Z

src/main/java/Task.java

+        protected String taskType;
+        protected int taskIndex;


Perhaps you would like to remove this unused variable?

Add Delete function

Add Save function

Add Find function

Add Java Documentation

Cazh1 added 5 commits August 31, 2023 15:23

Add Greet and Exit functions

cefd18d

Add Echo function

a30a0be

Add List and Add function

ff4554d

Add Mark-as-Done function

899542c

Tweak the code to comply with coding standard

cd10722

karishma-t reviewed Sep 7, 2023

View reviewed changes

ShaniceTang reviewed Sep 7, 2023

View reviewed changes

Cazh1 and others added 12 commits September 7, 2023 20:56

Update code logic to use Object Class

95c15bd

Add tracking for types of tasks

3d50f0a

Update methods to use Object class

c7b6dac

Update methods to use Object class

a5d5914

Merge branch 'master' of https://github.com/Cazh1/ip

50f175c

Refactor code

8e1aead

Add Error Handling function

3dbdfbc

Add Error Handling function

544d7c9

Revert "Add Error Handling function"

060f8b7

This reverts commit 3dbdfbc.

Merge branch 'master' into branch-Level-5

712e602

Merge pull request #1 from Cazh1/branch-Level-5

20a68c2

Add Error Handling function

Add Automated Text UI Testing

16e8cbf

woowenjun99 reviewed Sep 14, 2023

View reviewed changes

Cazh1 and others added 10 commits September 16, 2023 00:19

Update Exception Handler to cover more exceptions

5cfdcb5

Organise files into Packages

8ff14d8

Update Organization of Package

335ff3f

Update Error handling code - clean up

578c87e

Update Automated Text UI Testing

ca8c8e3

Update code with regards to TA comments

23dfdee

Add Delete function

ee3e90e

Add Save function

fe43edd

Update Saving capability

b7a4dd3

Merge pull request #2 from Cazh1/branch-Level-6

f583868

Add Delete function

Cazh1 and others added 26 commits September 27, 2023 15:57

Merge pull request #3 from Cazh1/branch-Level-7

6b15613

Add Save function

Add import for Delete in main

4c2227f

Update previousList format

0a23d97

Add MoreOOP for Storage and Command

0e39d2e

Add MoreOOP for TextUi

e8b4ef4

Add Find function

32f1853

Add Java Documentation

96ac6d1

Merge pull request #4 from Cazh1/branch-Level-9

f41f811

Add Find function

Merge pull request #5 from Cazh1/branch-JavaDoc

b3bcec5

Add Java Documentation

Update README.md

d0f4404

Update README.md

f6ef0c4

Update README.md

5d0ee0d

Update README.md

2ff6d44

Update README.md

9f93c2e

Update README.md

a077f54

Update README.md

bd265bb

Update README.md

e6b2f51

Update README.md

449b98d

Update README.md

bfdc87d

Update README.md

fb8bcff

Update README.md

f691c78

Update README.md

8f7dbd9

Update README.md

531399a

Update Code Quality

9b0876a

Update README.md

d17d6b4

Update Code Quality

7ee1694

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Chua Zhong Heng] iP #63

[Chua Zhong Heng] iP #63

Cazh1 commented Sep 4, 2023

karishma-t left a comment

karishma-t Sep 7, 2023

karishma-t Sep 7, 2023

karishma-t Sep 7, 2023

karishma-t Sep 7, 2023

ShaniceTang left a comment

ShaniceTang Sep 7, 2023

ShaniceTang Sep 7, 2023

ShaniceTang Sep 7, 2023

ShaniceTang Sep 7, 2023

woowenjun99 left a comment

woowenjun99 Sep 14, 2023

woowenjun99 Sep 14, 2023

woowenjun99 Sep 14, 2023

woowenjun99 Sep 14, 2023

woowenjun99 Sep 14, 2023

woowenjun99 Sep 14, 2023

[Chua Zhong Heng] iP #63

Are you sure you want to change the base?

[Chua Zhong Heng] iP #63

Conversation

Cazh1 commented Sep 4, 2023

karishma-t left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShaniceTang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

woowenjun99 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment