[CS2113-T18-1] Movie Reviews #47

naz019 · 2022-10-18T15:18:45Z

No description provided.

nus-se-bot · 2022-10-20T04:12:20Z

@naz019 Closing this PR because this PR does not seem to comply with our requirements. Possible reasons:

You sent this PR to the wrong repo. Only PRs from your team repo should be sent here.
This PR is not sent from the master branch of your team repo.
Your team org is named incorrectly. It should be AY2223S1-CS2113-T18-1
If that is the case, you can reopen this PR after renaming the org with the correct name.

NayChi-7 · 2022-10-26T04:21:57Z

docs/DeveloperGuide.md

@@ -2,7 +2,7 @@

 ## Acknowledgements


In the Ui UML Diagram, the accessibility of the attributes and methods are represented by different symbols (such as diamonds, square etc). Maybe you might want to disable the skinparam to display as '+' and '-' as how we usually do those?

NayChi-7 · 2022-10-26T04:26:23Z

docs/DeveloperGuide.md

@@ -2,7 +2,7 @@

 ## Acknowledgements

-{list here sources of all reused/adapted ideas, code, documentation, and third-party libraries -- include links to the original source as well}


Media class is shown as abstract in the UML diagram. However, it is not implemented as an abstract class. Is it supposed to be just shown as 'normal' class in the UML diagram?

NayChi-7 · 2022-10-26T04:30:23Z

docs/DeveloperGuide.md

@@ -2,7 +2,7 @@

 ## Acknowledgements

-{list here sources of all reused/adapted ideas, code, documentation, and third-party libraries -- include links to the original source as well}
+AddressBook-Level3 https://github.com/se-edu/addressbook-level3

 ## Design & implementation


NayChi-7 · 2022-10-26T04:48:18Z

docs/DeveloperGuide.md

@@ -2,7 +2,7 @@

 ## Acknowledgements

-{list here sources of all reused/adapted ideas, code, documentation, and third-party libraries -- include links to the original source as well}
+AddressBook-Level3 https://github.com/se-edu/addressbook-level3

 ## Design & implementation


Added addCommand and findCommand sequence diagrams.

Added diagrams to developer guide

updated Developer Guide

Updated Developer's Guide

adding List/Sort Descriptions

Added testing for Parser

hughjazzman

Some comments! Some bugs are repeated, so make sure to fix them for all diagrams.

hughjazzman · 2022-10-27T09:27:31Z

docs/DeveloperGuide.md


-## Design & implementation
+![img.png](imgs/UiClass.png)


Note that this is non-standard UML notation. You can use the info here to change settings for PlantUML: nus-cs2113-AY2122S1/forum#114

hughjazzman · 2022-10-27T09:33:08Z

docs/DeveloperGuide.md

+The command component enables users to make changes to their review list. The command word is taken from the first word
+of the user input, and is processed through the `Parser` class. The class diagram shows how the Commands parent class is
+implemented, as well as its extended classes.
+![img.png](imgs/CommandsClass.png)


Might this italicised String execute be a bug?

hughjazzman · 2022-10-27T09:35:35Z

docs/DeveloperGuide.md

+DukeException error is thrown.
+4. A new variable of type Media parent class, `toAdd`, is then created. The `AddCommand` function is then called to add
+the Movie or Tv Show `toAdd` into the review list, `reviewList`.
+![img_1.png](imgs/AddCommandSequence.png)


Consider adding : to signify these as instance of their classes.

hughjazzman · 2022-10-27T09:38:22Z

docs/DeveloperGuide.md

+4. A new variable of type Media parent class, `toAdd`, is then created. The `AddCommand` function is then called to add
+the Movie or Tv Show `toAdd` into the review list, `reviewList`.
+![img_1.png](imgs/AddCommandSequence.png)
+


Consider breaking up the diagram. If showing the sequence of AddComand, you can concentrate on the sequence that is unique to AddCommand. Reference frames could be useful.

hughjazzman · 2022-10-27T09:43:56Z

docs/DeveloperGuide.md

+4. A new variable of type Media parent class, `toAdd`, is then created. The `AddCommand` function is then called to add
+the Movie or Tv Show `toAdd` into the review list, `reviewList`.
+![img_1.png](imgs/AddCommandSequence.png)
+


There may be missing/extra lifelines here.

hughjazzman · 2022-10-27T09:44:43Z

docs/DeveloperGuide.md

+2. The `Parser` object calls on `executeList` which is responsible for creating a `ListCommand` Object. It then calls on its `execute` method to execute the proper actions.
+3. In this `execute` function, it loops through all the stored reviews and separates each review based on category and formats using the proper `toString` method.
+4. Finally, an output string is returned and the `Parser` class calls on the `UI` object to print the output to the user.  
+![img_2.png](imgs/ListCommandSequence.png)


This could be a bug, is this a self-invocation?

hughjazzman · 2022-10-27T09:45:59Z

docs/DeveloperGuide.md

+2. The `Parser` object calls on `executeList` which is responsible for creating a `ListCommand` Object. It then calls on its `execute` method to execute the proper actions.
+3. In this `execute` function, it loops through all the stored reviews and separates each review based on category and formats using the proper `toString` method.
+4. Finally, an output string is returned and the `Parser` class calls on the `UI` object to print the output to the user.  
+![img_2.png](imgs/ListCommandSequence.png)


This return might need to be dotted?

Edited User Guide

ppp edit

updated PPP

shortened PPP

updated PPP links

Added more javadoc

adding prof picture

updated favourites command

updated UG with latest output

updated sort

Fixed minor DG error

nus-se-bot closed this Oct 20, 2022

okkhoy reopened this Oct 26, 2022

NayChi-7 reviewed Oct 26, 2022

View reviewed changes

redders7 and others added 23 commits October 26, 2022 22:54

Added addCommand and findCommand sequence diagrams.

51fea35

Added addCommand and findCommand sequence diagrams.

74830be

Added addCommand and findCommand sequence diagrams.

Added diagrams to developer guide

ac14c92

Added diagrams to developer guide

43ef872

Added diagrams to developer guide

adding

9a02aa0

adding

a48b1da

adiding

ab227ef

adding

62f9950

adding

b81d77e

adding

fa8f2bb

updated Developer Guide

9e09080

Updated Developer Guide

44063b9

Added a parser test

4b27d66

Merge branch 'master' of https://github.com/AY2223S1-CS2113-T18-1b/tp

67baeaf

Merge pull request #72 from naz019/master

e79e743

updated Developer Guide

Merge branch 'master' of https://github.com/AY2223S1-CS2113-T18-1b/tp

2f43c8d

Updated Developer's Guide

1866147

Updated Developer's Guide

Merge branch 'master' of https://github.com/AY2223S1-CS2113-T18-1b/tp

a93df1f

adding

610cb68

Merge pull request #74 from matthewphua/branch-diagram-descriptions

9eae96c

adding List/Sort Descriptions

Merge branch 'master' of https://github.com/AY2223S1-CS2113-T18-1b/tp

292498f

Checkstyle error fixed

f88bb9a

Merge pull request #75 from indraneelrp/master

e099ef6

Added testing for Parser

hughjazzman reviewed Oct 27, 2022

View reviewed changes

indraneelrp and others added 2 commits October 28, 2022 12:30

Edited User Guide

03abb3a

Merge pull request #76 from indraneelrp/master

bbe9d95

Edited User Guide

indraneelrp and others added 30 commits November 7, 2022 19:49

Merge branch 'master' of https://github.com/AY2223S1-CS2113-T18-1b/tp

0bdc67d

Merge pull request #174 from indraneelrp/master

437890e

ppp edit

making ppp 2 pages

4ecdfc5

Merge pull request #175 from indraneelrp/master

2431f53

ppp edit

updated PPP

1815076

Merge pull request #176 from naz019/master

1f7259d

updated PPP

shortened PPP

d2efba2

Merge pull request #177 from naz019/master

c962c6c

shortened PPP

updated PPP links

2a0fd62

Merge pull request #178 from naz019/master

925902e

updated PPP links

Added javadoc

8d09bd9

Merge branch 'master' of https://github.com/AY2223S1-CS2113-T18-1b/tp

b4cad22

style edit

b6487b6

adding

dbc9d81

Merge pull request #179 from indraneelrp/master

93ad3e9

Added more javadoc

Merge pull request #180 from matthewphua/branch-parser-tests

c4abf5e

adding prof picture

updated favourites command

392c265

fixed checkstyle

8e102ad

updated UG

8a5897e

Merge pull request #181 from naz019/master

857b4b5

updated favourites command

Merge branch 'master' of https://github.com/AY2223S1-CS2113-T18-1b/tp

7c7f5df

updated sort command

9b9ad6b

Merge branch 'master' of https://github.com/AY2223S1-CS2113-T18-1b/tp

1d49c6e

Merge pull request #182 from indraneelrp/master

4b23e4c

updated UG with latest output

fixed checkstyle

ef6a4b2

Merge branch 'master' of https://github.com/AY2223S1-CS2113-T18-1b/tp

59e8440

fixed magic number

872e4e3

Merge pull request #183 from naz019/master

8a471aa

updated sort

Fixed minor DG error

38c23cf

Merge pull request #184 from redders7/master

c7873e5

Fixed minor DG error

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CS2113-T18-1] Movie Reviews #47

[CS2113-T18-1] Movie Reviews #47

naz019 commented Oct 18, 2022

nus-se-bot commented Oct 20, 2022

NayChi-7 Oct 26, 2022

NayChi-7 Oct 26, 2022

NayChi-7 Oct 26, 2022

NayChi-7 Oct 26, 2022

hughjazzman left a comment

hughjazzman Oct 27, 2022

hughjazzman Oct 27, 2022

hughjazzman Oct 27, 2022

hughjazzman Oct 27, 2022

hughjazzman Oct 27, 2022

hughjazzman Oct 27, 2022

hughjazzman Oct 27, 2022

		@@ -2,7 +2,7 @@

		## Acknowledgements

		{list here sources of all reused/adapted ideas, code, documentation, and third-party libraries -- include links to the original source as well}

[CS2113-T18-1] Movie Reviews #47

Are you sure you want to change the base?

[CS2113-T18-1] Movie Reviews #47

Conversation

naz019 commented Oct 18, 2022

nus-se-bot commented Oct 20, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hughjazzman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment