Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-F08-2] D.A.V.E. #106

Open
wants to merge 430 commits into
base: master
Choose a base branch
from

Merge pull request #212 from tiif/branch-update-acknowledgement

f2eb6cb
Select commit
Loading
Failed to load commit list.
Open

[CS2103T-F08-2] D.A.V.E. #106

Merge pull request #212 from tiif/branch-update-acknowledgement
f2eb6cb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 20, 2023 in 0s

77.85% (+2.59%) compared to 517b785

View this Pull Request on Codecov

77.85% (+2.59%) compared to 517b785

Details

Codecov Report

Attention: 118 lines in your changes are missing coverage. Please review.

Comparison is base (517b785) 75.26% compared to head (f2eb6cb) 77.85%.

Files Patch % Lines
src/main/java/seedu/address/ui/ViewWindow.java 0.00% 37 Missing ⚠️
src/main/java/seedu/address/ui/MainWindow.java 0.00% 28 Missing ⚠️
src/main/java/seedu/address/ui/PersonCard.java 0.00% 8 Missing ⚠️
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% 6 Missing ⚠️
...eedu/address/logic/commands/AddMeetingCommand.java 90.38% 0 Missing and 5 partials ⚠️
.../seedu/address/logic/commands/EditLeadCommand.java 88.88% 0 Missing and 5 partials ⚠️
...ess/logic/commands/ConvertClientToLeadCommand.java 87.50% 2 Missing and 2 partials ⚠️
...ess/logic/commands/ConvertLeadToClientCommand.java 85.71% 2 Missing and 2 partials ⚠️
...ava/seedu/address/commons/util/CollectionUtil.java 0.00% 3 Missing ⚠️
...u/address/logic/commands/DeleteMeetingCommand.java 93.61% 0 Missing and 3 partials ⚠️
... and 9 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #106      +/-   ##
============================================
+ Coverage     75.26%   77.85%   +2.59%     
- Complexity      419      598     +179     
============================================
  Files            71       96      +25     
  Lines          1338     2005     +667     
  Branches        126      203      +77     
============================================
+ Hits           1007     1561     +554     
- Misses          301      390      +89     
- Partials         30       54      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov