Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-T11-1] StonksBook #80

Open
wants to merge 1,396 commits into
base: master
Choose a base branch
from

Conversation

sebastiantoh
Copy link

@sebastiantoh sebastiantoh commented Sep 15, 2020

StonksBook empowers salesmen to effectively curate a sales-optimised contact list and conveniently conduct data analysis to gain business insights and boost sales performance.

Criss-Wang pushed a commit to Criss-Wang/tp that referenced this pull request Sep 25, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2020

Codecov Report

Merging #80 into master will increase coverage by 2.46%.
The diff coverage is 97.03%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #80      +/-   ##
============================================
+ Coverage     72.31%   74.77%   +2.46%     
- Complexity      400      450      +50     
============================================
  Files            70       74       +4     
  Lines          1228     1324      +96     
  Branches        124      138      +14     
============================================
+ Hits            888      990     +102     
+ Misses          308      300       -8     
- Partials         32       34       +2     
Impacted Files Coverage Δ Complexity Δ
...edu/address/logic/commands/contact/AddCommand.java 100.00% <ø> (ø) 8.00 <0.00> (?)
.../address/logic/commands/contact/DeleteCommand.java 100.00% <ø> (ø) 7.00 <0.00> (?)
...du/address/logic/commands/contact/EditCommand.java 97.01% <ø> (ø) 12.00 <0.00> (?)
...du/address/logic/commands/contact/ListCommand.java 100.00% <ø> (ø) 2.00 <0.00> (?)
...address/logic/parser/contact/AddCommandParser.java 100.00% <ø> (ø) 5.00 <0.00> (?)
...ress/logic/parser/contact/DeleteCommandParser.java 100.00% <ø> (ø) 2.00 <0.00> (?)
...ddress/logic/parser/contact/EditCommandParser.java 92.30% <ø> (ø) 11.00 <0.00> (?)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 86.66% <86.95%> (-13.34%) 14.00 <10.00> (+2.00) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e3b78...4719f44. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #80 (83150d5) into master (b3e3b78) will decrease coverage by 0.77%.
The diff coverage is 82.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #80      +/-   ##
============================================
- Coverage     72.31%   71.54%   -0.78%     
- Complexity      400     1342     +942     
============================================
  Files            70      181     +111     
  Lines          1228     4466    +3238     
  Branches        124      642     +518     
============================================
+ Hits            888     3195    +2307     
- Misses          308     1050     +742     
- Partials         32      221     +189     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/seedu/address/commons/core/LogsCenter.java 78.37% <ø> (ø) 10.00 <0.00> (ø)
...ava/seedu/address/logic/commands/ClearCommand.java 50.00% <0.00%> (-50.00%) 1.00 <0.00> (-1.00)
...seedu/address/logic/commands/DarkThemeCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...eedu/address/logic/commands/LightThemeCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../address/logic/commands/sale/BreakdownCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...eedu/address/logic/commands/sale/StatsCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../seedu/address/logic/commands/tag/ListCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ress/logic/parser/contact/DeleteCommandParser.java 100.00% <ø> (ø) 2.00 <0.00> (?)
...rc/main/java/seedu/address/logic/LogicManager.java 77.77% <14.28%> (+2.77%) 8.00 <1.00> (+5.00)
... and 191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e3b78...83150d5. Read the comment docs.

nopenotj pushed a commit to nopenotj/tp that referenced this pull request Oct 8, 2020
…te-Contact

Make contact names unique and change delete to delete by name instead of index
GeNiaaz pushed a commit to GeNiaaz/tp that referenced this pull request Oct 11, 2020
chunyongg added a commit to chunyongg/Serenity that referenced this pull request Oct 12, 2020
BILLXYR pushed a commit to BILLXYR/tp that referenced this pull request Oct 18, 2020
iqbxl pushed a commit to iqbxl/fitNUS that referenced this pull request Oct 20, 2020
hakujitsu and others added 30 commits November 9, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants