Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[T2A2][W15-A4] Le Minh Phuc #273

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

[T2A2][W15-A4] Le Minh Phuc #273

wants to merge 13 commits into from

Commits on Jan 31, 2017

  1. Delete inline comments of a person's string representation, and separ… 

    …ate command strings into different blocks with comments before them
    @le-minhphuc
    le-minhphuc committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    cf5e48c View commit details
    Browse the repository at this point in the history

  2. Line 161: Delete unnecessary comment COMMAND_

    @le-minhphuc
    le-minhphuc committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    035e9e5 View commit details
    Browse the repository at this point in the history

  3. Line 198: Transfer inline comment to header comment on top

    @le-minhphuc
    le-minhphuc committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    3a847b2 View commit details
    Browse the repository at this point in the history

  4. Remove magic number in processProgramArgs()

    @le-minhphuc
    le-minhphuc committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    ce7f52e View commit details
    Browse the repository at this point in the history

  5. Line 366: Rewrite comment to be more concrete

    @le-minhphuc
    le-minhphuc committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    18eadb7 View commit details
    Browse the repository at this point in the history

  6. Line 414: Add description for splitCommandWordAndArgs() method

    @le-minhphuc
    le-minhphuc committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    84ddfac View commit details
    Browse the repository at this point in the history

  7. Remove inline comment

    @le-minhphuc
    le-minhphuc committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    a44082b View commit details
    Browse the repository at this point in the history

  8. Line wrapping in isDisplayIndexValidForLastPersonListingView method

    @le-minhphuc
    le-minhphuc committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    cdfabba View commit details
    Browse the repository at this point in the history

  9. Line wrapping in line 681

    @le-minhphuc
    le-minhphuc committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    6093b0b View commit details
    Browse the repository at this point in the history

  10. Delete unnecessary blank lines in createFileIfMissing method

    @le-minhphuc
    le-minhphuc committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    1b48660 View commit details
    Browse the repository at this point in the history

  11. Add @param and @return description for getLinesInFile method

    @le-minhphuc
    le-minhphuc committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    e59099d View commit details
    Browse the repository at this point in the history

  12. Specify return results for getNameFromPerson, getPhoneFromPerson, get… 

    …EmailFromPerson methods
    @le-minhphuc
    le-minhphuc committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    ae31ad6 View commit details
    Browse the repository at this point in the history

  13. Improve abstraction of removePrefixSign to removePrefix method

    @le-minhphuc
    le-minhphuc committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    ff3b1ab View commit details
    Browse the repository at this point in the history