[14.0][ADD] connector_oxigesti: export manufacturing and unbuild orders #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 14.0 #301 +/- ##
==========================================
- Coverage 46.37% 46.35% -0.03%
==========================================
Files 778 785 +7
Lines 13628 13824 +196
Branches 2984 3024 +40
==========================================
+ Hits 6320 6408 +88
- Misses 7143 7253 +110
+ Partials 165 163 -2 ☔ View full report in Codecov by Sentry. |
FrankC013
force-pushed
the
14.0-add-connector_oxigesti-export_mrp_production_unbuild
branch
6 times, most recently
from
ba942a8
to
865b196
Compare
FrankC013
force-pushed
the
14.0-add-connector_oxigesti-export_mrp_production_unbuild
branch
from
865b196
to
45be0b4
Compare
FrankC013
force-pushed
the
14.0-add-connector_oxigesti-export_mrp_production_unbuild
branch
3 times, most recently
from
cf78fd1
to
f80e2c3
Compare
eantones
requested changes
Sep 26, 2023
| mssql_type_map = {} | ||
| for k, v in self.PYTHON_TYPE_MAP.items(): | ||
| for t in v: | ||
| mssql_type_map[t] = k |
There was a problem hiding this comment.
Check if "t" is already in mssql_type_map, ValidationError if is
Comment on lines
249
to
254
| # check if schema exists to avoid injection | ||
| schema_exists = self._exec_sql( | ||
| "select 1 from sys.schemas where name=%s", (self.schema,) | ||
| ) | ||
| if not schema_exists: | ||
| raise pymssql.InternalError("The schema %s does not exist" % self.schema) |
There was a problem hiding this comment.
Remove these lines, this is covered by the cursor execution itself.
Comment on lines
+268
to
+263
| raise ValidationError( | ||
| _("Unexpected type %s for field %s") % (ttype, field) |
FrankC013
force-pushed
the
14.0-add-connector_oxigesti-export_mrp_production_unbuild
branch
from
f80e2c3
to
8199e91
Compare
FrankC013
force-pushed
the
14.0-add-connector_oxigesti-export_mrp_production_unbuild
branch
from
02f0896
to
35eadd1
Compare
FrankC013
force-pushed
the
14.0-add-connector_oxigesti-export_mrp_production_unbuild
branch
2 times, most recently
from
0f77b6f
to
8a2795a
Compare
eantones
approved these changes
Feb 13, 2024
eantones
force-pushed
the
14.0-add-connector_oxigesti-export_mrp_production_unbuild
branch
from
8a2795a
to
50cee39
Compare
eantones
force-pushed
the
14.0-add-connector_oxigesti-export_mrp_production_unbuild
branch
from
50cee39
to
8ebb248
Compare
…rence isn't informed
…hes the column type of the binding
…o_Orden_Produccion
eantones
force-pushed
the
14.0-add-connector_oxigesti-export_mrp_production_unbuild
branch
from
8ebb248
to
1960b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.