Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup! fix: non-ascii paths in git walker #489

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fixup! fix: non-ascii paths in git walker #489

merged 1 commit into from
Nov 29, 2024

Conversation

brianmcgee
Copy link
Member

Signed-off-by: Brian McGee [email protected]

@brianmcgee brianmcgee marked this pull request as draft November 29, 2024 11:11
@brianmcgee brianmcgee marked this pull request as ready for review November 29, 2024 11:15
@brianmcgee brianmcgee mentioned this pull request Nov 29, 2024
Merged
1 task
@brianmcgee brianmcgee merged commit f9fd60e into main Nov 29, 2024
33 checks passed
@brianmcgee brianmcgee deleted the fixup/non-ascii-paths branch November 29, 2024 11:32
jfly
jfly reviewed Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid I can't tell what was wrong before or how this fixed it. But thanks for adding a test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfly jfly jfly left review comments

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianmcgee @jfly