Merge pull request #62 from numtide/expose-cleanup-error

.github/workflows/go.yml

@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        go: [ '1.19' ]
+        go: [ '1.22' ]
     steps:
 
     - name: Set up Go ${{ matrix.go }}

.github/workflows/golangci-lint.yml

@@ -14,7 +14,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
+        with:
+          go-version: 1.22
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.51.2
+          version: v1.58.2

.github/workflows/release.yml

@@ -3,24 +3,21 @@ name: goreleaser
 on:
   push:
     tags:
-      - 'v*'
+      - "v*"
 
 jobs:
   goreleaser:
     runs-on: ubuntu-latest
     steps:
-      -
-        name: Checkout
+      - name: Checkout
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      -
-        name: Set up Go
+      - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.19
-      -
-        name: Run GoReleaser
+          go-version: 1.22
+      - name: Run GoReleaser
         uses: goreleaser/goreleaser-action@v5
         with:
           version: latest

command/cleanup.go

@@ -36,6 +36,7 @@ func CmdCleanup(c *cli.Context) (err error) {
 	} else {
 		// undeploy all closed pull requests
 		var deployed []string
+
 		deployed, err = listDeployedPullRequests(listScript)
 		if err != nil {
 			return err
@@ -48,10 +49,13 @@ func CmdCleanup(c *cli.Context) (err error) {
 		if err != nil {
 			return err
 		}
+
 		openPRs := make([]string, len(prs))
+
 		for i, pr := range prs {
 			openPRs[i] = fmt.Sprintf("pr-%d", *pr.Number)
 		}
+
 		log.Println("open PRs:", openPRs)
 
 		// Now get a list of all the deployed PRs that are not open
@@ -64,9 +68,20 @@ func CmdCleanup(c *cli.Context) (err error) {
 
 	log.Println("to undeploy:", toUndeploy)
 
+	var lastErr error
+
 	for _, name := range toUndeploy {
 		log.Println("Undeploying", name)
 
+		pullRequestID, err := strconv.Atoi(name)
+		if err != nil {
+			log.Println("Unable to parse pull request id: ", name)
+
+			lastErr = err
+
+			continue
+		}
+
 		cmd := exec.Command(c.Args().Get(0), c.Args()[1:]...) //#nosec
 		cmd.Stdout = os.Stdout
 		cmd.Stderr = os.Stderr
@@ -75,20 +90,15 @@ func CmdCleanup(c *cli.Context) (err error) {
 		if err != nil {
 			log.Println("undeploy error: ", err)
 
-			continue
-		}
-
-		pullRequestID, err := strconv.Atoi(name)
-		if err != nil {
-			log.Println("Unable to parse pull request id: ", name)
+			lastErr = err
 
 			continue
 		}
 
 		destroyGitHubDeployments(ctx, ghCli, owner, repo, pullRequestID, ignoreMissing)
 	}
 
-	return nil
+	return lastErr
 }
 
 func contains(item string, list []string) bool {

command/please_test.go

@@ -2,6 +2,6 @@ package command_test
 
 import "testing"
 
-func TestCmdPlease(t *testing.T) {
+func TestCmdPlease(_ *testing.T) {
 	// Write your code here
 }

gitsrc/gitsrc.go

@@ -69,34 +69,34 @@ func (x *gitSource) String(name string) (string, error) {
 
 // These are implemented to satisfy the altsrc.InputSourceContext interface
 
-func (x *gitSource) Int(name string) (int, error) {
+func (x *gitSource) Int(_ string) (int, error) {
 	return 0, ErrNotSupported
 }
 
-func (x *gitSource) Duration(name string) (time.Duration, error) {
+func (x *gitSource) Float64(_ string) (float64, error) {
 	return 0, ErrNotSupported
 }
 
-func (x *gitSource) Float64(name string) (float64, error) {
+func (x *gitSource) Duration(_ string) (time.Duration, error) {
 	return 0, ErrNotSupported
 }
 
-func (x *gitSource) StringSlice(name string) ([]string, error) {
+func (x *gitSource) StringSlice(_ string) ([]string, error) {
 	return nil, ErrNotSupported
 }
 
-func (x *gitSource) IntSlice(name string) ([]int, error) {
+func (x *gitSource) IntSlice(_ string) ([]int, error) {
 	return nil, ErrNotSupported
 }
 
-func (x *gitSource) Generic(name string) (cli.Generic, error) { //nolint:nolintlint,ireturn
+func (x *gitSource) Generic(_ string) (cli.Generic, error) { //nolint:nolintlint,ireturn
 	return nil, ErrNotSupported
 }
 
-func (x *gitSource) Bool(name string) (bool, error) {
+func (x *gitSource) Bool(_ string) (bool, error) {
 	return false, ErrNotSupported
 }
 
-func (x *gitSource) BoolT(name string) (bool, error) {
+func (x *gitSource) BoolT(_ string) (bool, error) {
 	return false, ErrNotSupported
 }

main.go

@@ -26,6 +26,5 @@ func main() {
 
 	if err := app.Run(os.Args); err != nil {
 		log.Fatal("ERROR:", err)
-		os.Exit(1)
 	}
 }