Remove assert_almost_equals from tests #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kai-Striega
approved these changes
Dec 4, 2023
tests/test_financial.py
Outdated
| @@ -740,4 +748,4 @@ def test_irr_maximum_iterations_exception(self): | |||
| cashflows = numpy.array([-40000, 5000, 8000, 12000, 30000]) | |||
|
|
|||
| with pytest.raises(npf.IterationsExceededError): | |||
| npf.irr(cashflows, maxiter=1, raise_exceptions=True) | |||
| npf.irr(cashflows, maxiter=1, raise_exceptions=True) | |||
There was a problem hiding this comment.
You've deleted the ending newline here, please add it back in
There was a problem hiding this comment.
Yes, I'll work on it right now!
Sorted the import block and added the new line
|
Hey! I have sorted the import block and added the new line back. |
|
Thanks, @ArCh12312, I've re-run the tests to make sure everything is ok. If it is, I'm glad to merge this. |
used the command ruff format ./test_financial.py to reformat the file.
|
Hey @Kai-Striega, I have reformatted the file using the command `ruff format ./test_financial.py'. Please review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#66 Fixed the issue
Changed assert_almost_equals to assert_allclose and a custom function(assert_decimal_close).
Had to create assert_decimal_close, which finds the absolute difference in values and compares it to a tolerance level.
Cannot use the
assert_allclosebecause it uses isfinite under the covers which does not support the Decimal type.See issue: numpy/numpy#9954