Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CircleCI config and GitHub workflow to redirect to CircleCI #90
base: main
Are you sure you want to change the base?
Add CircleCI config and GitHub workflow to redirect to CircleCI #90
Changes from 1 commit
76afabd
94d691e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be simplified with poetry. Poetry has the concept of dependency groups meaning we can install the doc dependencies by running
poetry install --with doc
. I think we will be required to change the makefile to work with poetry if we do go down that route though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying but even with the right dependencies in the docs group of the pyproject.toml file, when I do "poetry install --with docs" nothing is installed. To be fair none of the other groups work for me either and "poetry install --with test" or "poetry install --with bench" also don't do anything. I'm really not familiar with poetry so I wonder if I'm missing a step somewhere...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The argument should be
docs
, notdoc
(note the extras
) - that's on me, I got it wrong in the above comment. It might be that you have installed all the dependencies already in your local environment, which is why it's not installing anything else.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I figured the doc vs docs thing looking at
numpy-financial/pyproject.toml
Line 49 in 1656639
Still, it doesn't work: