Skip to content

Commit

Permalink
Merge pull request #68 from numpy/ci/lint-as-own-step
Browse files Browse the repository at this point in the history
TST: Make linting own step in CI pipeline
  • Loading branch information
Kai-Striega authored Nov 12, 2023
2 parents 3e8a716 + 3a5b7ea commit 7d3b75e
Show file tree
Hide file tree
Showing 2 changed files with 52 additions and 7 deletions.
51 changes: 51 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
name: Lint

on:
push:
branches:
- "*"
pull_request:
branches:
- main

permissions:
contents: read # to fetch code (actions/checkout)

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
test_lint:
name: Lint
# If using act to run CI locally the github object does not exist and the usual skipping should not be enforced
if: "github.repository == 'numpy/numpy-financial' || github.repository == ''"
runs-on: ubuntu-22.04
strategy:
matrix:
python-version: ['3.11']

steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
submodules: recursive

- name: Setup Python
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}

- name: Install Python packages
run: |
python -m pip install --upgrade pip poetry
poetry env use ${{ matrix.python-version }}
poetry install --with=test --with=lint
- name: Lint with flake8
run: |
set -euo pipefail
# stop the build if there are Python syntax errors or undefined names
poetry run flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
# The GitHub editor is 127 chars wide
poetry run flake8 . --ignore=F401,F403,W503,E226 --count --max-complexity=10 --max-line-length=127 --statistics
8 changes: 1 addition & 7 deletions .github/workflows/pythonpackage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,7 @@ jobs:
run: |
python -m pip install --upgrade pip poetry
poetry env use ${{ matrix.python-version }}
poetry install --with=test --with=lint
- name: Lint with flake8
run: |
# stop the build if there are Python syntax errors or undefined names
poetry run flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
# The GitHub editor is 127 chars wide
poetry run flake8 . --ignore=F401,F403,W503,E226 --count --max-complexity=10 --max-line-length=127 --statistics
poetry install --with=test
- name: Test with pytest
run: |
poetry run pytest

0 comments on commit 7d3b75e

Please sign in to comment.