-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding my final project #28
base: master
Are you sure you want to change the base?
Conversation
Good effort, but there are some fundamental misconceptions that sent you in the wrong direction. The comments below follow a linear reading of the notebook. "Due to the Laplace operators"—>just delete this preamble to the statement. The system is 3D for physical reasons, and the Laplace operator can be written in any dimension. "Cavity Flow will be set up as pressure driven flow"—> I wonder what your rationale is for this? Pressure-driven flows are, for example, flow in a channel or flow in a pipe. If you add a source term F to the u-momentum equation, you are, in fact, adding a horizontal pressure gradient everywhere, one that will drive the whole flow field in that direction. Cavity flow is, rather, driven by the boundary conditions: you have one side of the domain with an imposed u-velocity. But that only applies on the boundary, not the entire domain! Anyway, it looks like this statement did not carry through to the rest of your work, because I see no source term F in the momentum equation. At some point, you changed from lower-case to upper-case P for the pressure. "As you probably noticed in the Burger's Equation above…"—>That's the Navier-Stokes equation, not Burgers' ... and note that it is Mr. Burgers, so Burgers' equation (not Burger's). "which when combined with an equation such as PV=nRT"—>unfinished or malformed sentence. "To form the Poisson Equation a source term is added to the equation, thus providing our driving pressure for our pressure driven flow." —> There is a conceptual error here. The pressure Poisson equation does have a source term on the right, but that does not make this a pressure-driven flow. Boundary & Initial Conditions "image courtesy of ..." —> Generally, this means you are using the image with permission from the copyright holder. In your case, you're probably resorting to fair use (as this is an educational purpose), and you should add a "Credit" instead (perhaps as an image caption). The code in this notebook follows closely the one in step 11 of CFD Python. I noticed that your pressure-Poisson iterative solver works with a while-loop and a convergence criterion, rather than a fixed number of iterations like our simpler solver in step 11. This is an improvement (although you should also have a maximum number of iterations to exit if the solver is not converging). In your function A collocated grid does not make your code blow up: it should work just fine, only with some checker-board pattern on the pressure field. After your cavity flow calculation, you present some post-processing with "there must be a negative pressure gradient in the flow pulling the flow down into the cavity" —> all the discussion in this paragraph is confusing. And certainly an immersed boundary method is not required to solve in an extended domain in the shape of a T. By the way, there is no point in trying to compare different results without a matching Reynolds number! (Physically, they should not match.) I'm afraid you reach incorrect conclusions from applying a flawed simulation approach in the first place. I don't think you can just plug in a pressure update using a Helmholtz equation into a Navier-Stokes solver. You need to think deeply about what it means to have acoustic waves in an incompressible-flow situation. Typos |
Adding everyones projects
No description provided.