-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: streaming source #191
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 94.06% 94.04% -0.02%
==========================================
Files 56 54 -2
Lines 2241 2167 -74
Branches 131 131
==========================================
- Hits 2108 2038 -70
+ Misses 102 97 -5
- Partials 31 32 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Running the E2E locally after the change
|
Signed-off-by: Sidhant Kohli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please run an endurance for a day
@@ -1,22 +0,0 @@ | |||
TAG ?= stable | |||
PUSH ?= false | |||
IMAGE_REGISTRY = quay.io/numaio/numaflow-python/async-source:${TAG} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kindly reminder to also delete the registry from quay.io.
PR to make source streaming in nature.
We have removed the sync source from the implementation
Refer: https://grpc.io/docs/guides/performance/#python
Streaming RPCs create extra threads for receiving and possibly sending the messages, which makes streaming RPCs much slower than unary RPCs in gRPC Python, unlike the other languages supported by gRPC.
Using asyncio could improve performance.