Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coffeescript integration #113

Closed
wants to merge 1 commit into from
Closed

Coffeescript integration #113

wants to merge 1 commit into from

Conversation

slavaGanzin
Copy link
Contributor

works with https://github.com/terraqout/jupyter-nodejs until notablemind/jupyter-nodejs#16 isn't merged

Code review and any help appreciated

if language == 'coffeescript'
if language not in @loadedExtensions
@_execute '%load_ext coffee', => @loadedeExtensions.push language
"%%coffee bare no-prompt\n"+code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main issue with this is that it flies in the face of the JavaScript kernel I'm currently using, ijavascript. It would be nice to unify the JS/Node kernels, otherwise we're going to have this special matrix of handlers for Hydrogen.

Then again, if there's a way we can tell which kernel is setup, we can defer to the right one.

@slavaGanzin
Copy link
Contributor Author

@rgbkrk I just use nodejs kernel because there coffeescript is ready to integrate.
Is iJavascript better or supported well? I use ipython for three days, so all kernels look alike.

This non-generic approach isn't good at all, there are many X->JS and I'll write something generic when have a time for that.

@rgbkrk
Copy link
Member

rgbkrk commented Sep 20, 2015

Thinking on this, I might make a PR to the notable mind js kernel to have coffeescript, babel, etc. be kernelspecs you can install instead of using magics.

@slavaGanzin
Copy link
Contributor Author

would be great

@willwhitney
Copy link
Collaborator

My guiding principle is to not include any language-specific code in Hydrogen. Kyle's suggestion sounds like the best way to deal with this — that's what kernelspecs are for, after all!

I also want to have a way to switch which kernel you're using with a file, but I'm swamped right now, so I'm not sure when that's going to happen.

@rgbkrk having a single Babel kernel would be awesome.

@slavaGanzin
Copy link
Contributor Author

@rgbkrk Notify me, please, when you finish with kernels. I'll implement hydrogen part

@slavaGanzin
Copy link
Contributor Author

Finally we can use this: https://github.com/n-riesco/jp-coffeescript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants