Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup error handling code #1500

Merged
merged 1 commit into from
Nov 18, 2024
Merged

chore: cleanup error handling code #1500

merged 1 commit into from
Nov 18, 2024

Conversation

likid1412
Copy link
Contributor

cleanup error handling code, use net.ErrClosed instead of strings.Contains

@likid1412
Copy link
Contributor Author

ready for review

@likid1412 likid1412 changed the title cleanup error handling code chore: cleanup error handling code Oct 25, 2024
@likid1412
Copy link
Contributor Author

fix #1483

@mreiferson mreiferson merged commit b28375d into nsqio:master Nov 18, 2024
7 of 8 checks passed
@mreiferson
Copy link
Member

thanks

@mreiferson mreiferson mentioned this pull request Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@likid1412 @mreiferson