Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for new upload/download requests #804

Merged
merged 11 commits into from
Jun 5, 2024
Merged

Add tests for new upload/download requests #804

merged 11 commits into from
Jun 5, 2024

Conversation

tatiana-nspcc
Copy link
Contributor

Close #803.

@evgeniiz321
Copy link
Contributor

evgeniiz321 commented May 30, 2024 •
edited
Loading

Looks good. But we need to update the commit hash here to use the right rest gw version - https://github.com/nspcc-dev/neofs-testcases/blob/master/.github/workflows/run-tests.yml#L147. I would like to see all rest tests passed in this PR. As for now they are in a bad state - https://rest.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/392-1717028436/index.html#suites/a11163bd22126f454509aaaa5f118c96

@tatiana-nspcc tatiana-nspcc force-pushed the 803-new-rest-requests branch 2 times, most recently from a1ef9b0 to 8a01295 Compare May 30, 2024 21:43
@roman-khimov
Copy link
Member

Conflicts.

@tatiana-nspcc tatiana-nspcc force-pushed the 803-new-rest-requests branch from 8a01295 to 7f8bec9 Compare May 31, 2024 14:43
@tatiana-nspcc
Copy link
Contributor Author

Conflicts.

I've rebased it.

roman-khimov
roman-khimov reviewed May 31, 2024
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last two can be squashed

pytest_tests/lib/helpers/http_gate.py Show resolved Hide resolved
pytest_tests/tests/services/rest_gate/test_rest_gate_new.py Outdated Show resolved Hide resolved
@tatiana-nspcc tatiana-nspcc force-pushed the 803-new-rest-requests branch from 7f8bec9 to 2392e34 Compare June 3, 2024 17:34
@tatiana-nspcc
helpers: Rename HTTP -> REST
7a96175 
Signed-off-by: Tatiana Nesterenko <[email protected]>
@tatiana-nspcc
helpers: Modify default get and get_by_attribute requests
1113361 
Signed-off-by: Tatiana Nesterenko <[email protected]>
@tatiana-nspcc
helpers: Add new upload function for the REST gateway
266aa40 
Signed-off-by: Tatiana Nesterenko <[email protected]>
@tatiana-nspcc
helpers: Add a new function for getting epoch duration
d7e9c8e 
Using GET "/network-info" request.

Signed-off-by: Tatiana Nesterenko <[email protected]>
@tatiana-nspcc
rest_gate: Add tests for new upload/download requests
41ecd8a 
Signed-off-by: Tatiana Nesterenko <[email protected]>
@tatiana-nspcc
helpers: Rename file http_gate.py (HTTP -> REST)
13d5725 
Signed-off-by: Tatiana Nesterenko <[email protected]>
@tatiana-nspcc
lib: Rename dir and file http_gw/http_utils.py (HTTP->REST)
6bf05db 
Signed-off-by: Tatiana Nesterenko <[email protected]>
@tatiana-nspcc tatiana-nspcc force-pushed the 803-new-rest-requests branch from 2392e34 to 4307374 Compare June 4, 2024 16:04
@tatiana-nspcc tatiana-nspcc force-pushed the 803-new-rest-requests branch from 4307374 to bf3e393 Compare June 4, 2024 16:06
@roman-khimov roman-khimov requested a review from evgeniiz321 June 4, 2024 16:16
@roman-khimov roman-khimov merged commit 8f508fb into master Jun 5, 2024
4 of 5 checks passed
@roman-khimov roman-khimov deleted the 803-new-rest-requests branch June 5, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@evgeniiz321 evgeniiz321 evgeniiz321 approved these changes

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for new upload/download requests
3 participants
@tatiana-nspcc @evgeniiz321 @roman-khimov