Fix/object parts changes #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new (0.41.0+) node versions store object's part information as a LINK's payload, not a header info. Also, add payload size info, since it is also available now. The helper was also renamed since its name can be confused with the storage groups. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
requested review from
cthulhu-rider,
evgeniiz321 and
roman-khimov
as code owners
roman-khimov
reviewed
May 2, 2024
No. I am not sure if it can be done without additional support in our utils. For now we can only put big object and stop after N seconds? |
|
Let's create an issue and think about it separately then. |
|
@roman-khimov, test repo or cli? I agree such a test will be helpful, but do not see any easy solution without some object parts creation util. |
|
Test. We'll untangle from it. |
roman-khimov
approved these changes
May 3, 2024
Parts of a split object cannot be deleted after the new split scheme. Ever, not when the root object is locked. Drop the outdated test and adapt the remaining control ones to the updated helpers. Closes #784. Signed-off-by: Pavel Karpy <[email protected]>
Such operations are prohibited with the new split scheme. Signed-off-by: Pavel Karpy <[email protected]>
Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/object-parts-changes
branch
from
a752942 to
1a3deb5
Compare
evgeniiz321
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.