Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

object: enable additional lock tests #782

Merged
merged 1 commit into from
Apr 19, 2024
Merged

object: enable additional lock tests #782

merged 1 commit into from
Apr 19, 2024

Conversation

roman-khimov
Copy link
Member

@roman-khimov
object: enable additional lock tests, fix #535
4b7b207 
They should work with v2 split.

Signed-off-by: Roman Khimov <[email protected]>
@roman-khimov
Copy link
Member Author

The only that has failed is https://rest.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/1517-1713527737/index.html#suites/295ed2e000f8fa6f3ade59cc13b98615/ae1199423652598b/
and it's acceptable to me at this stage, deletion is prevented and code can be discussed separately.

carpawell
carpawell approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We found it unusable, we fixed it, we enable it back. Code/error changes (if any) can be applied via another PR IMO.

@roman-khimov roman-khimov merged commit 234941b into master Apr 19, 2024
1 of 2 checks passed
@roman-khimov roman-khimov deleted the unlock-lock-tests branch April 19, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carpawell carpawell carpawell approved these changes

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

@evgeniiz321 evgeniiz321 Awaiting requested review from evgeniiz321 evgeniiz321 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roman-khimov @carpawell