tests: add multiple ir deployment test

Signed-off-by: Evgeniy Zayats <[email protected]>

neofs-testlib/neofs_testlib/env/env.py

@@ -58,6 +58,7 @@ def __init__(self, neofs_env_config: dict = None):
         self.neofs_s3_authmate_path = os.getenv("NEOFS_S3_AUTHMATE_BIN", "./neofs-s3-authmate")
         self.neofs_s3_gw_path = os.getenv("NEOFS_S3_GW_BIN", "./neofs-s3-gw")
         self.neofs_rest_gw_path = os.getenv("NEOFS_REST_GW_BIN", "./neofs-rest-gw")
+        self.alphabet_wallets_dir = NeoFSEnv._generate_temp_dir(prefix="ir_alphabet")
         # nodes inside env
         self.storage_nodes = []
         self.inner_ring_nodes = []
@@ -76,14 +77,6 @@ def sn_rpc(self):
             return self.storage_nodes[0].endpoint
         raise ValueError("No storage nodes configured in this env")
 
-    @property
-    def alphabet_wallets_dir(self):
-        if len(self.inner_ring_nodes) > 0:
-            if self.inner_ring_nodes[0].alphabet_wallet.address == "":
-                raise ValueError("Alphabet Wallets has not beet initialized")
-            return os.path.dirname(self.inner_ring_nodes[0].alphabet_wallet.path)
-        raise ValueError("No Inner Ring nodes configured in this env")
-
     @property
     def network_config(self):
         if len(self.inner_ring_nodes) > 0:
@@ -112,10 +105,23 @@ def generate_cli_config(self, wallet: NodeWallet):
         return cli_config_path
 
     @allure.step("Deploy inner ring node")
-    def deploy_inner_ring_node(self):
-        new_inner_ring_node = InnerRing(self)
-        new_inner_ring_node.start()
-        self.inner_ring_nodes.append(new_inner_ring_node)
+    def deploy_inner_ring_nodes(self, count=1):
+        for _ in range(count):
+            new_inner_ring_node = InnerRing(self)
+            new_inner_ring_node.generate_network_config()
+            self.inner_ring_nodes.append(new_inner_ring_node)
+
+        alphabet_wallets = self.generate_alphabet_wallets(self.inner_ring_nodes[0].network_config, size=count)
+
+        for ir_node in reversed(self.inner_ring_nodes):
+            ir_node.alphabet_wallet = alphabet_wallets.pop()
+
+        for ir_node in self.inner_ring_nodes:
+            ir_node.start(wait_until_ready=False)
+
+        for ir_node in self.inner_ring_nodes:
+            logger.info(f"Wait until IR: {ir_node} is READY")
+            ir_node._wait_until_ready()
 
     @allure.step("Deploy storage node")
     def deploy_storage_nodes(self, count=1, node_attrs: Optional[dict] = None):
@@ -162,28 +168,21 @@ def deploy_rest_gw(self):
         self.rest_gw.start()
         allure.attach(str(self.rest_gw), "rest_gw", allure.attachment_type.TEXT, ".txt")
 
-    @allure.step("Generate wallet")
-    def generate_wallet(
+    @allure.step("Generate storage wallet")
+    def generate_storage_wallet(
         self,
-        wallet_type: WalletType,
         prepared_wallet: NodeWallet,
         network_config: Optional[str] = None,
         label: Optional[str] = None,
     ):
         neofs_adm = self.neofs_adm(network_config)
 
-        if wallet_type == WalletType.STORAGE:
-            neofs_adm.morph.generate_storage_wallet(
-                alphabet_wallets=self.alphabet_wallets_dir,
-                storage_wallet=prepared_wallet.path,
-                initial_gas="10",
-                label=label,
-            )
-        elif wallet_type == WalletType.ALPHABET:
-            neofs_adm.morph.generate_alphabet(alphabet_wallets=prepared_wallet.path, size=1)
-            prepared_wallet.path += "/az.json"
-        else:
-            raise ValueError(f"Unsupported wallet type: {wallet_type}")
+        neofs_adm.morph.generate_storage_wallet(
+            alphabet_wallets=self.alphabet_wallets_dir,
+            storage_wallet=prepared_wallet.path,
+            initial_gas="10",
+            label=label,
+        )
 
         # neo-go requires some attributes to be set
         with open(prepared_wallet.path, "r") as wallet_file:
@@ -195,16 +194,52 @@ def generate_wallet(
 
         with open(prepared_wallet.path, "w") as wallet_file:
             json.dump(wallet_json, wallet_file)
-        ###
 
         prepared_wallet.address = wallet_utils.get_last_address_from_wallet(
             prepared_wallet.path, prepared_wallet.password
         )
 
+    @allure.step("Generate wallet")
+    def generate_alphabet_wallets(
+        self,
+        network_config: Optional[str] = None,
+        size: Optional[int] = 1,
+    ) -> list[NodeWallet]:
+        neofs_adm = self.neofs_adm(network_config)
+
+        neofs_adm.morph.generate_alphabet(alphabet_wallets=self.alphabet_wallets_dir, size=size)
+
+        generated_wallets = []
+
+        for generated_wallet in os.listdir(self.alphabet_wallets_dir):
+            # neo-go requires some attributes to be set
+            with open(os.path.join(self.alphabet_wallets_dir, generated_wallet), "r") as wallet_file:
+                wallet_json = json.load(wallet_file)
+
+            wallet_json["name"] = None
+            for acc in wallet_json["accounts"]:
+                acc["extra"] = None
+
+            with open(os.path.join(self.alphabet_wallets_dir, generated_wallet), "w") as wallet_file:
+                json.dump(wallet_json, wallet_file)
+
+            generated_wallets.append(
+                NodeWallet(
+                    path=os.path.join(self.alphabet_wallets_dir, generated_wallet),
+                    password=self.default_password,
+                    address=wallet_utils.get_last_address_from_wallet(
+                        os.path.join(self.alphabet_wallets_dir, generated_wallet), self.default_password
+                    ),
+                )
+            )
+        return generated_wallets
+
     @allure.step("Kill current neofs env")
     def kill(self):
-        self.rest_gw.process.kill()
-        self.s3_gw.process.kill()
+        if self.rest_gw:
+            self.rest_gw.process.kill()
+        if self.s3_gw:
+            self.s3_gw.process.kill()
         for sn in self.storage_nodes:
             sn.process.kill()
         for ir in self.inner_ring_nodes:
@@ -305,7 +340,7 @@ def simple(cls, neofs_env_config: dict = None) -> "NeoFSEnv":
             )
         neofs_env = NeoFSEnv(neofs_env_config=neofs_env_config)
         neofs_env.download_binaries()
-        neofs_env.deploy_inner_ring_node()
+        neofs_env.deploy_inner_ring_nodes()
         neofs_env.deploy_storage_nodes(
             count=4,
             node_attrs={
@@ -386,12 +421,9 @@ def __init__(self, neofs_env: NeoFSEnv):
         self.neofs_env = neofs_env
         self.network_config = NeoFSEnv._generate_temp_file(extension="yml", prefix="ir_network_config")
         self.cli_config = NeoFSEnv._generate_temp_file(extension="yml", prefix="ir_cli_config")
-        self.alphabet_wallet = NodeWallet(
-            path=NeoFSEnv._generate_temp_dir(prefix="ir_alphabet"), address="", password=self.neofs_env.default_password
-        )
+        self.alphabet_wallet = None
         self.ir_node_config_path = NeoFSEnv._generate_temp_file(extension="yml", prefix="ir_node_config")
         self.ir_storage_path = NeoFSEnv._generate_temp_file(extension="db", prefix="ir_storage")
-        self.seed_nodes_address = f"{self.neofs_env.domain}:{NeoFSEnv.get_available_port()}"
         self.rpc_address = f"{self.neofs_env.domain}:{NeoFSEnv.get_available_port()}"
         self.p2p_address = f"{self.neofs_env.domain}:{NeoFSEnv.get_available_port()}"
         self.grpc_address = f"{self.neofs_env.domain}:{NeoFSEnv.get_available_port()}"
@@ -405,7 +437,6 @@ def __str__(self):
             Inner Ring:
             - Alphabet wallet: {self.alphabet_wallet}
             - IR Config path: {self.ir_node_config_path}
-            - Seed nodes address: {self.seed_nodes_address}
             - RPC address: {self.rpc_address}
             - P2P address: {self.p2p_address}
             - GRPC address: {self.grpc_address}
@@ -419,7 +450,7 @@ def __getstate__(self):
         del attributes["process"]
         return attributes
 
-    def start(self):
+    def generate_network_config(self):
         if self.process is not None:
             raise RuntimeError("This inner ring node instance has already been started")
         logger.info(f"Generating network config at: {self.network_config}")
@@ -431,40 +462,48 @@ def start(self):
             config_path=self.network_config,
             custom=Path(network_config_template).is_file(),
             morph_endpoint=self.rpc_address,
-            alphabet_wallets_path=self.alphabet_wallet.path,
+            alphabet_wallets_path=self.neofs_env.alphabet_wallets_dir,
             default_password=self.neofs_env.default_password,
         )
-        logger.info("Generating alphabet wallets")
-        self.neofs_env.generate_wallet(WalletType.ALPHABET, self.alphabet_wallet, network_config=self.network_config)
-        logger.info(f"Generating IR config at: {self.ir_node_config_path}")
 
+    def start(self, wait_until_ready=True):
+        logger.info(f"Generating IR config at: {self.ir_node_config_path}")
         ir_config_template = "ir.yaml"
 
+        pub_keys_of_existing_ir_nodes = [
+            wallet_utils.get_last_public_key_from_wallet(ir_node.alphabet_wallet.path, ir_node.alphabet_wallet.password)
+            for ir_node in self.neofs_env.inner_ring_nodes
+        ]
+
+        seed_node_addresses_of_existing_ir_nodes = [ir_node.p2p_address for ir_node in self.neofs_env.inner_ring_nodes]
+
         NeoFSEnv.generate_config_file(
             config_template=ir_config_template,
             config_path=self.ir_node_config_path,
             custom=Path(ir_config_template).is_file(),
             wallet=self.alphabet_wallet,
-            public_key=wallet_utils.get_last_public_key_from_wallet(
-                self.alphabet_wallet.path, self.alphabet_wallet.password
-            ),
+            public_keys=pub_keys_of_existing_ir_nodes,
             ir_storage_path=self.ir_storage_path,
-            seed_nodes_address=self.seed_nodes_address,
+            seed_nodes_addresses=seed_node_addresses_of_existing_ir_nodes,
             rpc_address=self.rpc_address,
             p2p_address=self.p2p_address,
             grpc_address=self.grpc_address,
             ir_state_file=self.ir_state_file,
+            peers_min_number=int(
+                len(self.neofs_env.inner_ring_nodes) - (len(self.neofs_env.inner_ring_nodes) - 1) / 3 - 1
+            ),
+            set_roles_in_genesis=str(False if len(self.neofs_env.inner_ring_nodes) == 1 else True).lower(),
         )
         logger.info(f"Generating CLI config at: {self.cli_config}")
         NeoFSEnv.generate_config_file(
             config_template="cli_cfg.yaml", config_path=self.cli_config, wallet=self.alphabet_wallet
         )
         logger.info(f"Launching Inner Ring Node:{self}")
         self._launch_process()
-        logger.info("Wait until IR is READY")
-        self._wait_until_ready()
-
-        self.neofs_env.neofs_adm
+        logger.info(f"Launched Inner Ring Node:{self}")
+        if wait_until_ready:
+            logger.info("Wait until IR is READY")
+            self._wait_until_ready()
 
     def _launch_process(self):
         self.stdout = NeoFSEnv._generate_temp_file(prefix="ir_stdout")
@@ -477,7 +516,7 @@ def _launch_process(self):
             stderr=stderr_fp,
         )
 
-    @retry(wait=wait_fixed(10), stop=stop_after_attempt(10), reraise=True)
+    @retry(wait=wait_fixed(10), stop=stop_after_attempt(50), reraise=True)
     def _wait_until_ready(self):
         neofs_cli = self.neofs_env.neofs_cli(self.cli_config)
         result = neofs_cli.control.healthcheck(endpoint=self.grpc_address, post_data="--ir")
@@ -538,7 +577,7 @@ def __getstate__(self):
     def start(self, fresh=True):
         if fresh:
             logger.info("Generating wallet for storage node")
-            self.neofs_env.generate_wallet(WalletType.STORAGE, self.wallet, label=f"sn{self.sn_number}")
+            self.neofs_env.generate_storage_wallet(self.wallet, label=f"sn{self.sn_number}")
             logger.info(f"Generating config for storage node at {self.storage_node_config_path}")
 
             sn_config_template = "sn.yaml"
@@ -679,7 +718,7 @@ def __getstate__(self):
     def start(self):
         if self.process is not None:
             raise RuntimeError(f"This s3 gw instance has already been started:\n{self}")
-        self.neofs_env.generate_wallet(WalletType.STORAGE, self.wallet, label="s3")
+        self.neofs_env.generate_storage_wallet(self.wallet, label="s3")
         logger.info(f"Generating config for s3 gw at {self.config_path}")
         self._generate_config()
         logger.info(f"Launching S3 GW: {self}")
@@ -763,7 +802,7 @@ def __getstate__(self):
     def start(self):
         if self.process is not None:
             raise RuntimeError(f"This rest gw instance has already been started:\n{self}")
-        self.neofs_env.generate_wallet(WalletType.STORAGE, self.wallet, label="rest")
+        self.neofs_env.generate_storage_wallet(self.wallet, label="rest")
         logger.info(f"Generating config for rest gw at {self.config_path}")
         self._generate_config()
         logger.info(f"Launching REST GW: {self}")

neofs-testlib/neofs_testlib/env/templates/ir.yaml

@@ -14,12 +14,12 @@ morph:
   dial_timeout: 5s # Timeout for RPC client connection to sidechain
   reconnections_number: 5  # number of reconnection attempts
   reconnections_delay: 5s  # time delay b/w reconnection attempts
-  validators: # List of hex-encoded 33-byte public keys of sidechain validators to vote for at application startup; can be omitted if equals `consensus.committee`
-    - {{ public_key }}
   consensus: # Local consensus launch mode activated only when 'endpoint.client' is unset.
     magic: 15405 # Network magic. Must be unsigned integer in range [1:4294967295]
     committee: # Initial committee
+      {%- for public_key in public_keys %}
       - {{ public_key }} # Hex-encoded public key
+      {%- endfor %}
     storage: # Blockchain storage
       type: boltdb # One of following storage types:
         # boltdb (local BoltDB)
@@ -31,31 +31,20 @@ morph:
     time_per_block: 1s # Optional time period (approximate) between two adjacent blocks. Defaults to 15s.
       # Must not be negative
     seed_nodes:
+      {%- for seed_nodes_address in seed_nodes_addresses %}
       - {{ seed_nodes_address }}
-    max_traceable_blocks: 2102400 # Optional length of the chain accessible to smart contracts. Defaults to 2102400.
-      # Must not be greater than 4294967295
+      {%- endfor %}
     rpc: # Optional RPC settings
       listen: # Optional list of network addresses to listen Neo RPC on. By default, protocol is not served
         # TCP addresses in 'host:port' format
         - {{ rpc_address }}
     p2p: # Optional P2P settings
-      dial_timeout: 5s # Optional maximum duration a single peer dial may take. Defaults to 5s. Must not be negative
-      proto_tick_interval: 2s # Optional time period between protocol ticks with each connected peer. Defaults to 2s.
-        # Must not be negative
       listen: # Optional list of network addresses to listen Neo P2P on. By default, protocol is not served
         # TCP addresses in 'host:port' format
         - {{ p2p_address }}
-      peers: # Optional peer settings
-        min: 0 # Optional minimum number of peers a node needs for normal operation. Defaults to consensus minimum
-          # of 'committee' size (ceil of 2/3N-1). Must not be greater than 2147483647. Note that consensus service
-          # won't start until at least 'min' number of peers are connected
-        max: 10 # Optional limits of maximum number of peers dealing with the node. Defaults to 100. Must not be
-          # greater than 2147483647
-        attempts: 5 # How many peers node should try to dial after falling under 'min' count. Defaults to 'min'+10.
-          # Must not be greater than 2147483647
-      ping: # Optional settings of pinging mechanism
-        interval: 30s # Optional time period between pings. Defaults to 30s. Must not be negative
-        timeout: 90s # Optional time period to wait for pong. Defaults to 1m. Must not be negative
+      peers:
+        min: {{ peers_min_number }}
+    set_roles_in_genesis: {{ set_roles_in_genesis }}
 
 fschain_autodeploy: true
 
@@ -69,7 +58,9 @@ mainnet:
 
 control:
   authorized_keys:  # List of hex-encoded 33-byte public keys that have rights to use the control service
-    - {{ public_key }}
+    {%- for public_key in public_keys %}
+    - {{ public_key }} # Hex-encoded public key
+    {%- endfor %}
   grpc:
     endpoint: {{ grpc_address }}  # Endpoint that is listened by the control service; disabled by default