Simplify recurrent request handling (except Object service)
#3081
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3081 +/- ##
==========================================
+ Coverage 22.12% 22.21% +0.09%
==========================================
Files 794 772 -22
Lines 59563 59025 -538
==========================================
- Hits 13176 13112 -64
+ Misses 45483 45027 -456
+ Partials 904 886 -18 ☔ View full report in Codecov by Sentry. |
This will simplify subsequent refactoring with the abandonment of `github.com/nspcc-dev/neofs-api-go/v2` module: gRPC handlers are going to completely replace current `Server` interface definitions from `pkg/services` space. Signed-off-by: Leonard Lyubich <[email protected]>
This inlines components previously defined as neofs-api-go `Server` interfaces wrapping each other one-by-one into the gRPC server handlers. The object service is big, and kept for now: it's going to be changed as well soon. In addition to reducing packages, components and code, this will make it easier to deprecate `github.com/nspcc-dev/neofs-api-go/v2` module in the near future. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
avoid-apigo-drop-subsvcs
branch
from
df258d3 to
c5b0800
Compare
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
| } | ||
|
|
||
| // CurrentEpoch returns the latest cached epoch. | ||
| func (c *cfg) CurrentEpoch() uint64 { return c.networkState.CurrentEpoch() } |
There was a problem hiding this comment.
why GetNetworkMap but CurrentEpoch?
There was a problem hiding this comment.
this is a simple getter while GetNetworkMap can fail. I didnt think about this much tbh
| apicontainer "github.com/nspcc-dev/neofs-api-go/v2/container" | ||
| protocontainer "github.com/nspcc-dev/neofs-api-go/v2/container/grpc" | ||
| apirefs "github.com/nspcc-dev/neofs-api-go/v2/refs" | ||
| refs "github.com/nspcc-dev/neofs-api-go/v2/refs/grpc" |
There was a problem hiding this comment.
should this be protorefs? just to make it meaningful according to the other aliases
There was a problem hiding this comment.
there is no refs package in SDK root level, so we can do w/o alias (considering that apigo will leave)
one more cut from #3057, continues #3079