Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control: add network settings management via ir control #3059

Merged
merged 1 commit into from
Dec 28, 2024

control: add network management via ir control

3f32aae
Select commit
Loading
Failed to load commit list.
Merged

control: add network settings management via ir control #3059

control: add network management via ir control
3f32aae
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 27, 2024 in 0s

21.95% (-0.48%) compared to 08bd8d3

View this Pull Request on Codecov

21.95% (-0.48%) compared to 08bd8d3

Details

Codecov Report

Attention: Patch coverage is 1.80587% with 1305 lines in your changes missing coverage. Please review.

Project coverage is 21.95%. Comparing base (08bd8d3) to head (3f32aae).

Files with missing lines Patch % Lines
pkg/services/control/ir/service.pb.go 4.14% 463 Missing ⚠️
pkg/services/control/ir/service_neofs.pb.go 0.00% 192 Missing ⚠️
pkg/innerring/network.go 0.00% 130 Missing ⚠️
pkg/services/control/ir/service_grpc.pb.go 0.00% 88 Missing ⚠️
cmd/neofs-cli/modules/control/notary_request.go 0.00% 71 Missing ⚠️
pkg/services/control/ir/server/calls.go 0.00% 65 Missing ⚠️
pkg/services/control/ir/service.go 0.00% 44 Missing ⚠️
cmd/neofs-cli/modules/control/notary_list.go 0.00% 43 Missing ⚠️
cmd/neofs-cli/modules/control/notary_sign.go 0.00% 43 Missing ⚠️
pkg/services/control/ir/rpc.go 0.00% 42 Missing ⚠️
... and 13 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3059      +/-   ##
==========================================
- Coverage   22.43%   21.95%   -0.48%     
==========================================
  Files         792      797       +5     
  Lines       58538    59823    +1285     
==========================================
+ Hits        13132    13135       +3     
- Misses      44506    45787    +1281     
- Partials      900      901       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov