node/object: Fix Put op condition checking requests with copies number #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3042 +/- ##
=======================================
Coverage 22.63% 22.63%
=======================================
Files 791 791
Lines 58616 58615 -1
=======================================
Hits 13265 13265
+ Misses 44453 44452 -1
Partials 898 898 ☔ View full report in Codecov by Sentry. |
Regression from 5076fe2. Previously, the operation always failed on in-container nodes for requests with specified number of copies. Actually, it must fail requests with TTL=1 regardless of container composition. Signed-off-by: Leonard Lyubich <[email protected]>
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
bugfix/object-put-copies
branch
from
6728c47 to
a0a4df1
Compare
roman-khimov
approved these changes
Dec 4, 2024
Although such option setting is redundant, there is no reason to deny service of these requests. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
bugfix/object-put-copies
branch
from
3a43f4c to
8dd6a65
Compare
roman-khimov
approved these changes
Dec 5, 2024
carpawell
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raised in https://github.com/nspcc-dev/neofs-sdk-go/actions/runs/12164435066/job/33926084474#step:4:141