Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node/put/acl: Do not treat small objects as big #2783

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

carpawell
Copy link
Member

SplitID may be nil for small objects too (the same way it is for the new V2 split scheme). Do not try to search for a non-existing first object for small objects.

SplitID may be nil for small objects too (the same way it is for the new V2
split scheme). Do not try to search for a non-existing first object for small
objects.

Signed-off-by: Pavel Karpy <[email protected]>
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 22.02%. Comparing base (9ca1fbd) to head (d8c0c1d).
Report is 5 commits behind head on master.

Files Patch % Lines
pkg/services/object/acl/eacl/v2/headers.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2783      +/-   ##
==========================================
+ Coverage   22.00%   22.02%   +0.01%     
==========================================
  Files         789      789              
  Lines       47212    47225      +13     
==========================================
+ Hits        10390    10401      +11     
- Misses      35930    35931       +1     
- Partials      892      893       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roman-khimov roman-khimov merged commit 5023d85 into master Mar 22, 2024
14 of 17 checks passed
@roman-khimov roman-khimov deleted the fix/acl-for-put-small-objects branch March 22, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants