Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.git: update tests workflow to use new dev env #2765

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

evgeniiz321
Copy link

No description provided.

@evgeniiz321 evgeniiz321 self-assigned this Mar 6, 2024
@evgeniiz321 evgeniiz321 marked this pull request as draft March 6, 2024 01:38
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.04%. Comparing base (2840694) to head (9a81700).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2765   +/-   ##
=======================================
  Coverage   22.04%   22.04%           
=======================================
  Files         787      787           
  Lines       46738    46738           
=======================================
  Hits        10302    10302           
  Misses      35553    35553           
  Partials      883      883           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evgeniiz321 evgeniiz321 force-pushed the ezayats/new-tests branch 2 times, most recently from 1ff58e8 to e025c16 Compare March 6, 2024 04:02
@evgeniiz321
Copy link
Author

evgeniiz321 commented Mar 6, 2024

@roman-khimov

RuntimeError: Command: ./neofs-adm --config /tmp/tmp_filectguuaknnt.yml morph generate-storage-wallet --alphabet-wallets '/tmp/tmp_dirhmbpkwoook' --storage-wallet '/tmp/tmp_fileuafanshixc' --label 'sn3' --initial-gas 10
  Error:
  return code: 1
  output: Error: invalid GAS amount : invalid decimal format

It seems like a bug here - https://github.com/nspcc-dev/neofs-node/blob/master/cmd/neofs-adm/internal/modules/morph/generate.go#L159
I guess instead of refillGasAmountFlag, there should be storageGasCLIFlag

@carpawell
Copy link
Member

@evgeniiz321, #2766 should help

@evgeniiz321 evgeniiz321 force-pushed the ezayats/new-tests branch 2 times, most recently from 3a1cd30 to 3a000b9 Compare March 7, 2024 00:53
@evgeniiz321 evgeniiz321 marked this pull request as ready for review March 7, 2024 01:22
@evgeniiz321 evgeniiz321 marked this pull request as draft March 7, 2024 01:23
@evgeniiz321 evgeniiz321 marked this pull request as ready for review March 12, 2024 02:47
@roman-khimov roman-khimov merged commit 3e1d75c into nspcc-dev:master Mar 12, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants