Upgrade NeoFS SDK with eacl changes #2618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Behavior change: response headers are no longer processed because eACL may include rules over request headers only. Signed-off-by: Leonard Lyubich <[email protected]>
Adopt eACL changes. Signed-off-by: Leonard Lyubich <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2618 +/- ##
==========================================
- Coverage 29.74% 29.52% -0.22%
==========================================
Files 408 400 -8
Lines 31215 30773 -442
==========================================
- Hits 9284 9086 -198
+ Misses 21119 20883 -236
+ Partials 812 804 -8
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -58,7 +59,7 @@ func boolToString(b bool) string { | |||
| } | |||
|
|
|||
| // PrettyPrintTableEACL print extended ACL in table format. | |||
| func PrettyPrintTableEACL(cmd *cobra.Command, table *eacl.Table) { | |||
| func PrettyPrintTableEACL(cmd *cobra.Command, table eacl.Table) { | |||
| return nil, errors.New("invalid action (expected 'allow' or 'deny')") | ||
| case "allow": | ||
| action = eacl.ActionAllow | ||
| case "deny": |
There was a problem hiding this comment.
Don't we have these strings somewhere?
| ops[i] = acl.OpObjectSearch | ||
| case "getrange": | ||
| ops[i] = acl.OpObjectRange | ||
| case "getrangehash": |
| "github.com/nspcc-dev/neofs-sdk-go/user" | ||
| ) | ||
|
|
||
| // node is wrapper over cfg providing interface needed by app components. |
There was a problem hiding this comment.
Do we need another wrapper?
| // static | ||
|
|
||
| node Node | ||
|
|
There was a problem hiding this comment.
Why
oh
why
is
it
always
like
this?
|
too outdated, wontfix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eaclpackage neofs-sdk-go#526