Skip to content

Commit

Permalink
morph: increase buffer for notification handling routines
Browse files Browse the repository at this point in the history
10 is too low value for practice. It is not mind-blowing to receive tens of
notifications per block and, moreover, it was already seen in real networks.
Refs #3007.

Signed-off-by: Pavel Karpy <[email protected]>
  • Loading branch information
carpawell committed Dec 6, 2024
1 parent a93ea37 commit 19c72bf
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Changelog for NeoFS Node

### Changed
- Local object PUT op with copies number set to 1 is allowed now (#3042)
- Number of cuncurrenly handled notifications from the chain was increased from 10 to 100 (#3043)

### Removed

Expand Down
2 changes: 1 addition & 1 deletion cmd/neofs-node/morph.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func listenMorphNotifications(c *cfg) {
// the client cannot make RPC requests if
// the notification channel is not being
// read by another goroutine.
const listenerPoolCap = 10
const listenerPoolCap = 100

Check warning on line 69 in cmd/neofs-node/morph.go

View check run for this annotation

Codecov / codecov/patch

cmd/neofs-node/morph.go#L69

Added line #L69 was not covered by tests

lis, err := event.NewListener(event.ListenerParams{
Logger: c.log,
Expand Down
2 changes: 1 addition & 1 deletion pkg/morph/event/listener.go
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ func NewListener(p ListenerParams) (Listener, error) {
// defaultPoolCap is a default worker
// pool capacity if it was not specified
// via params
const defaultPoolCap = 10
const defaultPoolCap = 100

Check warning on line 578 in pkg/morph/event/listener.go

View check run for this annotation

Codecov / codecov/patch

pkg/morph/event/listener.go#L578

Added line #L578 was not covered by tests

switch {
case p.Logger == nil:
Expand Down

0 comments on commit 19c72bf

Please sign in to comment.