Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some binder and conda env tweaks #821

Merged
merged 9 commits into from
Sep 23, 2024
Merged

Some binder and conda env tweaks #821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1baba46
use earthaccess as environment name
jhkennedy Sep 20, 2024
8a6e5b3
rename binder dir
jhkennedy Sep 20, 2024
1df99b8
binder deps inventory
jhkennedy Sep 20, 2024
6aafea1
Binder doesn't appear to need anything special as our top level noteb…
jhkennedy Sep 20, 2024
273a2b7
unrestrict python version in environment file
jhkennedy Sep 20, 2024
3ab0b93
quote pip command
jhkennedy Sep 21, 2024
01f307b
update changelog
jhkennedy Sep 21, 2024
0ac0270
cleanup changelog whitespace
jhkennedy Sep 21, 2024
81e11cb
Apply CHANGELOG.md suggestions from PR review
jhkennedy Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,19 @@
[**@Sherwin-14**](https://github.com/betolink),
[**@mfisher87**](https://github.com/mfisher87)



### Fixed

- Removed Broken Link "Introduction to NASA earthaccess"
([#779](https://github.com/nsidc/earthaccess/issues/779))
([**@Sherwin-14**](https://github.com/Sherwin-14))

### Removed

- Remove `binder/` directory, as we no longer need a special [binder](https://mybinder.org)
environment with the top-level `environment.yml` introduced in
[#733](https://github.com/nsidc/earthaccess/issues/733)
([@jhkennedy](https://github.com/jhkennedy))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel too strongly about this, but I'd be OK omitting this from the change log. It's not really user facing. For developers, we have PRs and commits as history, so I don't feel we need things like this in changelog.


## [0.10.0] 2024-07-19

### Changed
Expand Down
24 changes: 0 additions & 24 deletions binder/environment.yml
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
name: earthaccess-dev
name: earthaccess
channels:
- conda-forge
dependencies:
# This environment bootstraps pip, the actual dev environment
# is installed and managed with pip
- python=3.10

- python
- pip
- pip:
- --editable .[dev,test,docs]
- --editable ".[dev,test,docs]"
variables:
# Allow pip installs when conda environment is active
PIP_REQUIRE_VENV: 0
Expand Down
Loading