Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PR examples to Pull Request Template #820

Merged
merged 3 commits into from
Sep 20, 2024
+9 −0
Merged

Added PR examples to Pull Request Template #820

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fbc0f3
Added PR examples to Pull Request Template
Sherwin-14 Sep 20, 2024
3b026a5
Update .github/pull_request_template.md with proper link
Sherwin-14 Sep 20, 2024
26eb63f
Update .github/pull_request_template.md with proper link
Sherwin-14 Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ created the PR as a non-draft, don't worry, you can still change it to a draft u
before getting started.
- [ ] Ensure an issue exists representing the problem being solved in this PR.
- [ ] Populate a descriptive title. For example, instead of "Updated README.md", use a
title such as "Add testing details to the contributor section of the README".
title such as "Add testing details to the contributor section of the README".[Click on this to see an example PR](https://github.com/nsidc/earthaccess/pull/763#event-14296896566)
Sherwin-14 marked this conversation as resolved.
Show resolved Hide resolved
- [ ] Populate the body of the pull request with:
- A clear description of the change you are proposing.
- Links to any issues resolved by this PR with text in the PR description, for
example `closes #1`. See
[GitHub docs - Linking a pull request to an issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue).
- [ ] Update `CHANGELOG.md` with details about your change in a section titled
`## Unreleased`. If such a section does not exist, please create one. Follow
[Common Changelog](https://common-changelog.org/) for your additions.
[Common Changelog](https://common-changelog.org/) for your additions.[Click on this to see an example PR](https://github.com/nsidc/earthaccess/pull/763#event-14296896566)
Sherwin-14 marked this conversation as resolved.
Show resolved Hide resolved
- [ ] Update the documentation and/or the `README.md` with details of changes to the
earthaccess interface, if any. Consider new environment variables, function names,
decorators, etc.
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@
[**@mfisher87**](https://github.com/mfisher87),
[**@betolink**](https://github.com/betolink))

- Added example PR links to pull request template
([#756](https://github.com/nsidc/earthaccess/issues/756))
[**@Sherwin-14**](https://github.com/betolink),
[**@mfisher87**](https://github.com/mfisher87)



### Fixed

- Removed Broken Link "Introduction to NASA earthaccess"
Expand Down
Loading