-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 to automated test matrix #571
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9d5e777
Add Python 3.12 to test matrix
chuckwondo d9c951c
Update lock file
chuckwondo e155ba0
Add lxml-html-clean dev dependency
chuckwondo 21f0574
Fix poetry failure in CI
chuckwondo 9831d26
Avoid poetry race condition build failure
chuckwondo 210da21
Pin min numpy for Python 3.12
chuckwondo 01ce0e4
Pin numpy, pyproj based on Python version
chuckwondo eec71ec
Drop Python 3.8 support
chuckwondo ff163cf
Loosen numpy and pyproj versions for Python <3.12
chuckwondo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,12 +17,16 @@ concurrency: | |
group: integration-tests-${{ github.ref }} | ||
cancel-in-progress: true | ||
|
||
defaults: | ||
run: | ||
shell: bash -l {0} | ||
|
||
jobs: | ||
test: | ||
integration-tests: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
python-version: [3.8, 3.9, "3.10", "3.11"] | ||
python-version: ["3.9", "3.10", "3.11", "3.12"] | ||
fail-fast: false | ||
|
||
steps: | ||
|
@@ -35,22 +39,29 @@ jobs: | |
id: full-python-version | ||
run: echo ::set-output name=version::$(python -c "import sys; print('-'.join(str(v) for v in sys.version_info))") | ||
- name: Install poetry | ||
run: | | ||
curl -sSL https://install.python-poetry.org | python3 - | ||
echo "$HOME/.poetry/bin" >> $GITHUB_PATH | ||
uses: abatilo/actions-poetry@v3 | ||
- name: Configure poetry | ||
run: poetry config virtualenvs.in-project true | ||
run: | | ||
poetry config virtualenvs.create true --local | ||
poetry config virtualenvs.in-project true --local | ||
poetry self add setuptools | ||
- name: Set up cache | ||
uses: actions/cache@v4 | ||
id: cache | ||
with: | ||
path: .venv | ||
key: venv-${{ runner.os }}-${{ steps.full-python-version.outputs.version }}-${{ hashFiles('**/poetry.lock') }} | ||
key: venv-${{ runner.os }}-${{ steps.full-python-version.outputs.version }}-${{ hashFiles('poetry.lock') }} | ||
- name: Ensure cache is healthy | ||
if: steps.cache.outputs.cache-hit == 'true' | ||
run: poetry run pip --version >/dev/null 2>&1 || rm -rf .venv | ||
- name: Install Dependencies | ||
if: ${{ !env.ACT }} | ||
run: poetry install | ||
- name: Install Dependencies | ||
if: ${{ env.ACT }} | ||
# When using `act` to run the workflow locally, the `poetry install` command | ||
# may fail due to network issues when running multiple Docker containers. | ||
run: poetry install || poetry install || poetry install | ||
- name: Test | ||
env: | ||
EARTHDATA_USERNAME: ${{ secrets.EDL_USERNAME }} | ||
|
@@ -59,4 +70,6 @@ jobs: | |
EARTHACCESS_TEST_PASSWORD: ${{ secrets.EDL_PASSWORD }} | ||
run: poetry run bash scripts/integration-test.sh | ||
- name: Upload coverage | ||
# Don't upload coverage when using the `act` tool to run the workflow locally | ||
if: ${{ !env.ACT }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TIL! |
||
uses: codecov/codecov-action@v4 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯