Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell checker for common spelling mistakes #558

Merged
merged 6 commits into from
May 12, 2024
Merged

Conversation

mfisher87
Copy link
Collaborator

@mfisher87 mfisher87 commented May 7, 2024

TODO: Fix errors

@chuckwondo
Copy link
Collaborator

@mfisher87, you should now be able to merge in recent changes from main and fix the spelling errors and get a successful build.

mfisher87 added 5 commits May 12, 2024 09:46
This directory was being created when I run pre-commit, and inside was
empty except `.cache/prettier`. Why is it happening? Not sure, but more
important is to prevent it from being committed if it happens to someone
else.
Notebooks are JSON data structures under the hood, and they include
baked-in output of Python code. This means:

* Images rendered may include random strings detected as "words" by
  codespell, e.g. `/te+/` was detected as `te`, which codespell
  reported as a misspelling of `the`, `be`, `we`, or `to`.
* Arbitrary output from Python code may contain legitimate misspellings
  or things that look like misspellings to codespell. E.g. `dout` may be
  considered a misspelling of `doubt`. We can't control this output.

This file is generated and we have no control over it.

* Package names, e.g. `astroid`, that we don't directly depend on, may
  trigger spelling errors. FWIW, "astroid" is a word, I just don't
  think we'll want to use it in our codebase, so it should be caught if
  we do.
* Packages we depend on may include spelling errors in their metadata,
  e.q. `pqdm` spells "parallelization" incorrectly in its description.
@mfisher87
Copy link
Collaborator Author

@chuckwondo apologies, should have marked this as draft before now :)

Copy link
Collaborator

@chuckwondo chuckwondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mfisher87 mfisher87 merged commit 5e45cc0 into main May 12, 2024
17 checks passed
@mfisher87 mfisher87 deleted the codespell branch May 12, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants