Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove readme symlink #534

Closed

Conversation

mfisher87
Copy link
Collaborator

@mfisher87 mfisher87 commented Apr 20, 2024

Depends on #533

It's a real pain that I can't chain PRs if I work on my fork.


📚 Documentation preview 📚: https://earthaccess--534.org.readthedocs.build/en/534/

@mfisher87 mfisher87 marked this pull request as ready for review April 20, 2024 00:06
@mfisher87 mfisher87 marked this pull request as draft April 20, 2024 00:06
@mfisher87
Copy link
Collaborator Author

Tried setting ready for review to trigger RTD build... I thought it would build for draft PRs. 🤷

mfisher87 and others added 11 commits April 24, 2024 18:49
Co-authored-by: Andy Barrett <[email protected]>
Co-authored-by: Andy Barrett <[email protected]>
Co-authored-by: Andy Barrett <[email protected]>
Previously, the README file was symlinked into our docs. This led to a
problem where we could only write links that worked within one of the
two systems. Docs links need to be relative to the symlink to render
correctly, and GitHub README links need to be relative to the original
file to work correctly.
@mfisher87 mfisher87 force-pushed the remove-readme-symlink branch from 9976a1a to 5be4824 Compare April 25, 2024 01:06
@mfisher87
Copy link
Collaborator Author

Closing and re-opening as a non-fork PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant