Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ASDC daac entry and cloud provider #518

Merged
merged 9 commits into from
Apr 16, 2024

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Apr 12, 2024

Closes #517


📚 Documentation preview 📚: https://earthaccess--518.org.readthedocs.build/en/518/

@danielfromearth danielfromearth linked an issue Apr 12, 2024 that may be closed by this pull request
@danielfromearth danielfromearth self-assigned this Apr 12, 2024
@danielfromearth
Copy link
Collaborator Author

Thanks @ckhowardASDC for your help with the URLs. I think this is ready for review now.

@danielfromearth danielfromearth marked this pull request as ready for review April 12, 2024 17:42
mfisher87
mfisher87 previously approved these changes Apr 13, 2024
@danielfromearth
Copy link
Collaborator Author

@mfisher87, the ReadTheDocs is failing — but I'm not sure why. And I can't find a way to just re-run that mkdocs build step without pushing a new commit. Do you know if that's possible?

mfisher87
mfisher87 previously approved these changes Apr 15, 2024
Copy link
Collaborator

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

EDIT: Reviewed the code before checking the comment. 👀

@mfisher87
Copy link
Collaborator

mfisher87 commented Apr 15, 2024

When RTD is failing, can you click "Details" on that check to view the build log? I thought anyone could but we may need to give you permissions in RTD to view it or something.

Here's the traceback:

Traceback (most recent call last):
  File "/home/docs/.asdf/installs/python/3.10.13/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/docs/.asdf/installs/python/3.10.13/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/mkdocs/__main__.py", line 361, in <module>
    cli()
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/mkdocs/__main__.py", line 283, in build_command
    cfg = config.load_config(**kwargs)
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/mkdocs/config/base.py", line 378, in load_config
    errors, warnings = cfg.validate()
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/mkdocs/config/base.py", line 230, in validate
    run_failed, run_warnings = self._validate()
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/mkdocs/config/base.py", line 188, in _validate
    self[key] = config_option.validate(value)
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/mkdocs/config/config_options.py", line 182, in validate
    return self.run_validation(value)
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/mkdocs/config/config_options.py", line 1064, in run_validation
    self.load_plugin_with_namespace(name, cfg)
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/mkdocs/config/config_options.py", line 1102, in load_plugin_with_namespace
    return (name, self.load_plugin(name, config))
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/mkdocs/config/config_options.py", line 1120, in load_plugin
    plugin_cls = self.installed_plugins[name].load()
  File "/home/docs/.asdf/installs/python/3.10.13/lib/python3.10/importlib/metadata/__init__.py", line 171, in load
    module = import_module(match.group('module'))
  File "/home/docs/.asdf/installs/python/3.10.13/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/mkdocs_jupyter/plugin.py", line 12, in <module>
    from . import convert
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/mkdocs_jupyter/convert.py", line 1, in <module>
    from nbconvert.filters.markdown_mistune import IPythonRenderer
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/nbconvert/__init__.py", line 5, in <module>
    from .exporters import *
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/nbconvert/exporters/__init__.py", line 1, in <module>
    from .asciidoc import ASCIIDocExporter
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/nbconvert/exporters/asciidoc.py", line 9, in <module>
    from .templateexporter import TemplateExporter
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/nbconvert/exporters/templateexporter.py", line 25, in <module>
    from lxml.html.clean import clean_html
  File "/home/docs/checkouts/readthedocs.org/user_builds/earthaccess/envs/518/lib/python3.10/site-packages/lxml/html/clean.py", line 18, in <module>
    raise ImportError(
ImportError: lxml.html.clean module is now a separate project lxml_html_clean.
Install lxml[html_clean] or lxml_html_clean directly.

@danielfromearth
Copy link
Collaborator Author

Yep, I can see the "Details" for the build. Not sure if we want to add this new lxml_html_clean package in the pyproject.toml dependencies. Will be able to look at this more later this afternoon.

This reverts commit 6319ecc.
@danielfromearth
Copy link
Collaborator Author

@mfisher87, with the poetry update reverted, everything checks out. If you approve (again 😄 ), I'll go ahead and merge.

Copy link
Member

@betolink betolink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@betolink betolink merged commit adfe8fa into main Apr 16, 2024
17 checks passed
@mfisher87 mfisher87 deleted the feature/issue-517-add-asdc-as-daac branch April 16, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ASDC as DAAC and cloud provider
3 participants