-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ASDC daac entry and cloud provider #518
Conversation
Thanks @ckhowardASDC for your help with the URLs. I think this is ready for review now. |
@mfisher87, the ReadTheDocs is failing — but I'm not sure why. And I can't find a way to just re-run that mkdocs build step without pushing a new commit. Do you know if that's possible? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
EDIT: Reviewed the code before checking the comment. 👀
When RTD is failing, can you click "Details" on that check to view the build log? I thought anyone could but we may need to give you permissions in RTD to view it or something. Here's the traceback:
|
Yep, I can see the "Details" for the build. Not sure if we want to add this new |
This reverts commit 6319ecc.
@mfisher87, with the poetry update reverted, everything checks out. If you approve (again 😄 ), I'll go ahead and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Closes #517
📚 Documentation preview 📚: https://earthaccess--518.org.readthedocs.build/en/518/