Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erroneous workflow cancellation #505

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

chuckwondo
Copy link
Collaborator

@chuckwondo chuckwondo commented Apr 1, 2024

The concurrency groups for both integration-tests and test-mindeps were named the same, creating a race condition such that whichever workflow was started first would be cancelled by the start of the second workflow. This fix gives them distinct group names to avoid erroneously cancelling one or the other.

Fixes #503


📚 Documentation preview 📚: https://earthaccess--505.org.readthedocs.build/en/505/

@jhkennedy
Copy link
Collaborator

Ah, nice! Thanks @chuckwondo

@jhkennedy jhkennedy merged commit 59e749e into nsidc:main Apr 1, 2024
12 checks passed
@mfisher87
Copy link
Collaborator

Great eye!

@chuckwondo chuckwondo deleted the erroneous-workflow-cancellation branch September 17, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test-mindeps erroneously cancelling test-mindeps jobs
3 participants